Last modified: 2014-07-09 15:28:47 UTC
Currently the Nostalgia skin is mediawiki/extensions. While technically all non-core skins are extensions, skins as a specific subset should be kept in mediawiki/skins.
Ha, I've just been discussing this with Chad this week and I was going to file a bug. I think there are three things that need to be done at about the same time: * Renaming or copying the actual repository, and hooking it up as a submodule in mediawiki/skins * Ensuring Nostalgia will work when placed in skins/ rather than extensions/ * Adjusting WMF config for the changes above
Also: * Merging [[mw:Extension:Nostalgia]] into [[mw:Skin:Nostalgia]].
(In reply to Bartosz Dziewoński from comment #1) > * Renaming or copying the actual repository It needs to be copied, in fact, otherwise older wmf versions will break. I requested the repository to be created.
(In reply to Bartosz Dziewoński from comment #1) > * Renaming or copying the actual repository, and hooking it up as a submodule > in mediawiki/skins This has been done by Chris. I'm writing the patches to do the rest right now.
Change 137198 had a related patch set uploaded by Bartosz Dziewoński: Adjust 'remoteBasePath' to the skins/ directory https://gerrit.wikimedia.org/r/137198
Change 137200 had a related patch set uploaded by Bartosz Dziewoński: Replace the Nostalgia extension with the Nostalgia skin https://gerrit.wikimedia.org/r/137200
Change 137203 had a related patch set uploaded by Bartosz Dziewoński: Add Nostalgia to $branchedSkins https://gerrit.wikimedia.org/r/137203
This should do. I'll get someone who knows what they're doing to check these. TODO undeploy mediawiki/extensions/Nostalgia when we can do it safely.
Change 137203 merged by jenkins-bot: Add Nostalgia to $branchedSkins https://gerrit.wikimedia.org/r/137203
Change 137198 merged by Chad: Adjust 'remoteBasePath' to the skins/ directory https://gerrit.wikimedia.org/r/137198
Change 137672 had a related patch set uploaded by Bartosz Dziewoński: Add Nostalgia to $branchedSkins https://gerrit.wikimedia.org/r/137672
Change 137672 merged by jenkins-bot: Add Nostalgia to $branchedSkins https://gerrit.wikimedia.org/r/137672
Change 137200 merged by jenkins-bot: Replace the Nostalgia extension with the Nostalgia skin https://gerrit.wikimedia.org/r/137200
(In reply to Bartosz Dziewoński from comment #1) > * Ensuring Nostalgia will work when placed in skins/ rather than extensions/ > * Adjusting WMF config for the changes above Done and done with the patches above. Left to do: * Update docs on mw.org * Empty the old repo, leaving just a pointer to the new repo (when possible, we'll need to wait for WMF deployment to roll out).
With https://gerrit.wikimedia.org/r/#/c/144002/ , WMF deployment is no longer using the Nostalgia extension, only the skin.
Docs updated, see [[mw:Skin:Nostalgia]].
Change 144988 had a related patch set uploaded by Bartosz Dziewoński: Remove everything except for short information in README and Nostalgia.php https://gerrit.wikimedia.org/r/144988
Change 144988 merged by jenkins-bot: Remove everything except for short information in README and Nostalgia.php https://gerrit.wikimedia.org/r/144988
All done!
