Last modified: 2014-08-21 20:55:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63283, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61283 - Prettify default theme/skin of mailman's listinfo pages
Prettify default theme/skin of mailman's listinfo pages
Status: VERIFIED FIXED
Product: Wikimedia
Classification: Unclassified
Mailing lists (Other open bugs)
wmf-deployment
All All
: Normal enhancement (vote)
: ---
Assigned To: John F. Lewis
theme skin
: design
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-12 19:44 UTC by MZMcBride
Modified: 2014-08-21 20:55 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2014-02-12 19:44:23 UTC
Pages such as <https://lists.wikimedia.org/mailman/listinfo/wikimedia-l> are currently super-ugly. We've discussed redesigning these pages, but these discussions seem to have fallen apart without action and I can't find a relevant bug report tracking this issue.
Comment 1 MZMcBride 2014-02-12 19:46:48 UTC
[[mailarchive:wikimedia-l/2013-April/125188.html]]
Comment 2 Andre Klapper 2014-02-12 21:40:35 UTC
Redesign can be seen here: 
https://lists.wikimedia.org/mailman/listinfo/mediawiki-l
Comment 3 Daniel Zahn 2014-02-12 21:43:32 UTC
:) nicest listinfo page i have seen so far i think:) nice! i always like to point out each list admin can do this for "their" list as well
Comment 4 MZMcBride 2014-02-13 01:33:04 UTC
Daniel: Can we change the default in our mailman installation? I imagine there's a template file somewhere that could be tweaked.
Comment 5 Thehelpfulone 2014-02-13 01:45:52 UTC
I remember working on this with Quim - the source is at https://github.com/quimgil/mailman-templates I believe. The problem is there's a tweak in the default file for the newer version of Mailman IIRC - so I suggested that we get that upgraded first /before/ we make these tweaks.

The first step to that would be upgrading sodium from lucid to precise which is https://rt.wikimedia.org/Ticket/Display.html?id=5420 (and has been waiting since July 2013!)
Comment 6 MZMcBride 2014-07-28 16:56:52 UTC
(In reply to Thehelpfulone from comment #5)

Any status update?
Comment 7 Thehelpfulone 2014-07-28 17:39:52 UTC
(In reply to MZMcBride from comment #6)
> (In reply to Thehelpfulone from comment #5)
> 
> Any status update?

Last I checked I was waiting for ops to upgrade sodium which would include a mailman update where the default listinfo template was changed. That way we could make sure the design works after installation of an update rather than doing it now then updating and potentially things breaking. Still waiting for an upgrade though!
Comment 8 John F. Lewis 2014-08-18 22:55:03 UTC
Spent the past two hours or so working with Thehelpfulone on this. We've got something. Gerrit patch coming shortly. It needs to be translated by our community as it is Wikimedia specific. Currently (as of writing) only English and Dutch is supported.
Comment 9 Gerrit Notification Bot 2014-08-18 22:56:52 UTC
Change 154964 had a related patch set uploaded by John F. Lewis:
mailman: use a new default theme (prettier mailman)

https://gerrit.wikimedia.org/r/154964
Comment 10 Quim Gil 2014-08-19 11:58:54 UTC
(In reply to John F. Lewis from comment #8)
> It needs to be translated by our community as it is Wikimedia specific. 

What is the recommended process for translators to get the English text and submit the translations?
Comment 11 Thehelpfulone 2014-08-19 12:00:27 UTC
On the most up-to-date version https://mailman.wmflabs.org/mailman/listinfo/test there's a 'Translate page' link on the side bar which links to https://meta.wikimedia.org/wiki/Mailing_lists/List_info on Meta where translations can be submitted.
Comment 12 John F. Lewis 2014-08-19 12:03:05 UTC
And are manually being shoved into Gerrit by me (I am in the process of adding about 15 which were translated over night)
Comment 13 Nemo 2014-08-19 13:20:20 UTC
It would be useful if the patch linked mailman docs on how changing default templates works. For instance, how does it handle language fallback? If it doesn't, are you planning to push that patch only if/when it has more translations than the default template?

(In reply to John F. Lewis from comment #12)
> And are manually being shoved into Gerrit by me (I am in the process of
> adding about 15 which were translated over night)

Sigh; thanks for the work. FWIW, the (horrible) script used by Fundraising for this (horrible) unsupported workflow seems to be https://git.wikimedia.org/blob/wikimedia%2Ffundraising%2Fcrm/HEAD/sites%2Fall%2Fmodules%2Fthank_you%2Fgenerators%2FRenderTranslatedPage.php
Comment 14 John F. Lewis 2014-08-19 13:25:52 UTC
(In reply to Nemo from comment #13)
> It would be useful if the patch linked mailman docs on how changing default
> templates works. For instance, how does it handle language fallback? If it
> doesn't, are you planning to push that patch only if/when it has more
> translations than the default template?

Language fall back currently is; Does the list's language/the selected language exist? Yes - Display it. No - Fall back to SEVER_LANGUAGE (English for us). We are pushing for every language we have enabled at the minute to have a translation for the theme. A few key parts such as subscribing etc. are default Mailman i18n so they will not be affected.

All languages have their own 'listinfo' so ultimately; we can push the patch and all languages we specified will have this theme while languages such as big5, will still use the old theme. This behaviour can be changed but is a lot of work of work and pointless to replace them with English templates.
Comment 15 Gerrit Notification Bot 2014-08-21 14:31:41 UTC
Change 154964 merged by Andrew Bogott:
mailman: use a new default theme (prettier mailman)

https://gerrit.wikimedia.org/r/154964
Comment 16 John F. Lewis 2014-08-21 14:43:53 UTC
Merged. I'll mark this as verified once Puppet updates Sodium :)
Comment 17 John F. Lewis 2014-08-21 16:20:47 UTC
And verified!
Comment 18 Quim Gil 2014-08-21 20:55:41 UTC
Well, this is beautiful. Thank you all for pursuing this task until the end!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links