Last modified: 2014-02-15 01:02:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63288, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 61288 - [Bugzilla 4.4 regression] Fix line height + line wrapping for Saved Searches + Saved Reports in sidebar


Summary:	[Bugzilla 4.4 regression] Fix line height + line wrapping for Saved Searches ...

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Bugzilla (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Highest normal (vote)
Target Milestone:	---
Assigned To:	Andre Klapper

URL:
Whiteboard:
Keywords:	code-update-regression

Duplicates:	61290 (view as bug list)
Depends on:	59889
Blocks:
	Show dependency tree / graph

Reported:	2014-02-13 01:02 UTC by Andre Klapper
Modified:	2014-02-15 01:02 UTC (History)
CC List:	14 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot of collapsed saved search links (46.97 KB, image/png) 2014-02-13 22:30 UTC, Krinkle	Details
Add an attachment (proposed patch, testcase, etc.)

Description Andre Klapper 2014-02-13 01:02:21 UTC

"Saved Searches" section now displays Saved Reports (a new feature in 4.4) at the bottom, but our custom code is rather interesting here (bug 59889). 

Applying my patch in https://gerrit.wikimedia.org/r/#/c/113051/ broke the line height, the line wrapping, and introduced indentation for the first item.

This is a regression due to upgrading to 4.4 but I decided to keep it as we have "Saved Reports" now at least (though they cannot be shared).

Comment 1 This, that and the other (TTO) 2014-02-13 01:33:37 UTC

*** Bug 61290 has been marked as a duplicate of this bug. ***

Comment 2 Gerrit Notification Bot 2014-02-13 02:23:39 UTC

Change 113073 had a related patch set uploaded by Aklapper:
Fix UI regression in side bar introduced in bug 59889

https://gerrit.wikimedia.org/r/113073

Comment 3 Tony Thomas 2014-02-13 13:03:30 UTC

The saved searches area looks so cluttered :( Hope it gets back to its original shape soon.

Comment 4 Krinkle 2014-02-13 22:30:12 UTC

Created attachment 14582 [details]
Screenshot of collapsed saved search links

Saved Searches links are no longer on their own line but collapsed

Comment 5 Gerrit Notification Bot 2014-02-14 20:18:02 UTC

Change 113073 merged by Dzahn:
Fix UI regression in side bar introduced in bug 59889

https://gerrit.wikimedia.org/r/113073

Comment 6 Andre Klapper 2014-02-14 20:31:52 UTC

Looks good to me: No indentation of first item anymore, correct line height, line wrapping, and the "Saved Reports" section between "Saved Searches" and "Links" is only shown when the user has at least one saved report.

Comment 7 Dan Garry 2014-02-15 01:02:27 UTC

Thanks for the timely fix. :-)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links