Last modified: 2014-03-21 22:56:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63334, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61334 - Upgrade python requests on tool labs
Upgrade python requests on tool labs
Status: ASSIGNED
Product: Tool Labs tools
Classification: Unclassified
Other (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-13 20:20 UTC by Arthur Richards
Modified: 2014-03-21 22:56 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Arthur Richards 2014-02-13 20:20:50 UTC
It looks like tool labs is using v1.1.0 of the Python package 'Requests' - this is grossly out of date (current is 2.2.1). There are a bunch of known SSL negotiation issues in older versions of Requests, and I suspect this is part of the problem being experienced by tools like Bingle and Bugello post-Bugzilla upgrade/migration. Can we please upgrade requests?
Comment 1 Marc A. Pelletier 2014-02-13 20:37:22 UTC
There are a fairly large number of tools that use requests, and it's not clear that both versions and cooexist peacefully.  Do we know if/how much the API has changed between v1 and v2 and how likely it is than an upgrade would break other tools?
Comment 2 Arthur Richards 2014-02-13 20:43:23 UTC
API changes from v1 to v2 are relatively minor:
http://www.python-requests.org/en/latest/api/#id1

It looks primarily like changes to the types of exceptions that may get raised, with the scariest looking thing being an update to the proxies API. I suspect this will be a fairly safe upgrade.
Comment 3 Marc A. Pelletier 2014-02-13 22:30:59 UTC
That, indeed, doesn't look overly disruptive.  I'll make a deb of the more recent version.
Comment 4 Arthur Richards 2014-02-14 01:42:39 UTC
Awesome! Thank you.
Comment 5 Arthur Richards 2014-02-21 16:11:25 UTC
Just wanted to dbl check on the status of this. Thanks!
Comment 6 Arthur Richards 2014-03-21 22:56:49 UTC
Note that tool labs on eqiad has an even older version of the requests library, which has caused further breakage in my tools.

tools.bugello@tools-login:~$ python
Python 2.7.3 (default, Feb 27 2014, 19:58:35)
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> requests.__version__
'0.8.2'

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links