Last modified: 2014-02-19 19:38:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63349, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61349 - Flow: a few fatals from TopicListEntry::toStorageRow in API call on mediawiki.org in 1.23wmf13
Flow: a few fatals from TopicListEntry::toStorageRow in API call on mediawiki...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-13 23:14 UTC by spage
Modified: 2014-02-19 19:38 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-02-13 23:14:18 UTC
I saw this in production fatal.log  This is on mediawiki.org and was prior to today's deploy of 1.23wmf14

[13-Feb-2014 11:32:05] Catchable fatal error: Argument 1 passed to Flow\Model\TopicListEntry::toStorageRow() must be an instance of Flow\Model\TopicListEntry, null given at /usr/local/apache/common-local/php-1.23wmf13/extensions/Flow/includes/Model/TopicListEntry.php on line 34
Server: mw1204
Method: GET
URL: http://www.mediawiki.org/w/api.php?action=query&format=json&list=flow&flowpage=Talk%3ASandbox&flowworkflow=rl7iby6wgksbpfno&flowparams=%7B%22topiclist%22%3A%7B%22offset-dir%22%3A%22fwd%22%2C%22offset-id%22%3A%22rocpxec9qyafpbwk%22%2C%22limit%22%3A10%2C%22render%22%3Atrue%7D%7D
Cookie: centralauth_User=<someUser>; centralauth_Token=<blahblah>; forceHTTPS=1; mediawikiwikiSession=<blahblah>; centralnotice_bucket=0-4.2

mw.org is now running 1.23wmf14.  That API URL now works for me, it returns valid JSON with a header element and a block containing 10 topics. Cleaned up it's

http://www.mediawiki.org/w/api.php?
    action=query&
    format=json&
    list=flow&
    flowpage=Talk:Sandbox&
    flowworkflow=rl7iby6wgksbpfno&
    flowparams={
        "topiclist": {
        "offset-dir": "fwd",
        "offset-id": "rocpxec9qyafpbwk",
        "limit": 10,
        "render": true
        }
    }

checking the February logs there was a nearly identical fatal on February 8 in 
fluorine:/a/mw-log/archive/fatal.log-20140208.gz, but on Talk:Flow 

Here's the backtrace of the one today, again the Feb 8 is nearly identical.

Backtrace:
#0 /usr/local/apache/common-local/php-1.23wmf13/extensions/Flow/includes/Model/TopicListEntry.php(34): Flow\Model\TopicListEntry::toStorageRow()
#1 [internal function]: Flow\Model\TopicListEntry::toStorageRow(NULL)
#2 /usr/local/apache/common-local/php-1.23wmf13/extensions/Flow/includes/Data/ObjectManager.php(630): call_user_func(Array, NULL)
#3 /usr/local/apache/common-local/php-1.23wmf13/extensions/Flow/includes/Data/ObjectManager.php(589): Flow\Data\BasicObjectMapper->toStorageRow(NULL)
#4 /usr/local/apache/common-local/php-1.23wmf13/extensions/Flow/includes/Data/Pager.php(107): Flow\Data\ObjectManager->serializeOffset(NULL, Array)
#5 /usr/local/apache/common-local/php-1.23wmf13/extensions/Flow/includes/Data/Pager.php(79): Flow\Data\Pager->makePagingLink('rev', NULL, 10)
#6 /usr/local/apache/common-local/php-1.23wmf13/extensions/Flow/includes/Data/Pager.php(40): Flow\Data\Pager->processPage('fwd', Object(Flow\Model\UUID), 10, NULL)
#7 /usr/local/apache/common-local/php-1.23wmf13/extensions/Flow/includes/Block/TopicList.php(279): Flow\Data\Pager->getPage()
#8 /usr/local/apache/common-local/php-1.23wmf13/extensions/Flow/includes/Block/TopicList.php(207): Flow\Block\TopicListBlock->getPage(Array)
#9 /usr/local/apache/common-local/php-1.23wmf13/extensions/Flow/includes/api/ApiQueryFlow.php(45): Flow\Block\TopicListBlock->renderAPI(Object(Flow\Templating), Array)
#10 /usr/local/apache/common-local/php-1.23wmf13/includes/api/ApiQuery.php(279): ApiQueryFlow->execute()
#11 /usr/local/apache/common-local/php-1.23wmf13/includes/api/ApiMain.php(861): ApiQuery->execute()
#12 /usr/local/apache/common-local/php-1.23wmf13/includes/api/ApiMain.php(362): ApiMain->executeAction()
#13 /usr/local/apache/common-local/php-1.23wmf13/includes/api/ApiMain.php(333): ApiMain->executeActionWithErrorHandling()
#14 /usr/local/apache/common-local/php-1.23wmf13/api.php(76): ApiMain->execute()
#15 /usr/local/apache/common-local/w/api.php(3): require('/usr/local/apac...')
#16 {main}
Comment 1 Gerrit Notification Bot 2014-02-14 17:53:19 UTC
Change 113380 had a related patch set uploaded by EBernhardson:
Gracefully handle empty pagination result

https://gerrit.wikimedia.org/r/113380
Comment 2 Gerrit Notification Bot 2014-02-14 18:00:31 UTC
Change 113380 merged by jenkins-bot:
Gracefully handle empty pagination result

https://gerrit.wikimedia.org/r/113380
Comment 3 Gerrit Notification Bot 2014-02-18 19:54:04 UTC
Change 114052 had a related patch set uploaded by EBernhardson:
Gracefully handle empty pagination result

https://gerrit.wikimedia.org/r/114052
Comment 4 Gerrit Notification Bot 2014-02-18 21:01:45 UTC
Change 114052 merged by jenkins-bot:
Gracefully handle empty pagination result

https://gerrit.wikimedia.org/r/114052

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links