Last modified: 2014-03-18 16:09:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63376, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61376 - Add {{Art Photo}} to the templates accepted by the GWtoolset
Add {{Art Photo}} to the templates accepted by the GWtoolset
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GWToolset (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://commons.wikimedia.org/wiki/Te...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-14 14:22 UTC by Jean-Fred
Modified: 2014-03-18 16:09 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jean-Fred 2014-02-14 14:22:46 UTC
{{Art Photo}} is a combination of {{Artwork}} and {{Photograph}}. It is very useful for photographs of 3D museum objects.

Please add {{Art Photo}} to the GWToolset configuration.

(It is my understanding that the GWToolset infers all its config from TemplateData − if so, I can submit a patch for this).
Comment 1 Gerrit Notification Bot 2014-02-14 15:35:52 UTC
Change 113369 had a related patch set uploaded by Dan-nl:
add Art Photo template to GWToolset

https://gerrit.wikimedia.org/r/113369
Comment 2 dan 2014-02-14 15:40:21 UTC
* GWToolset currently uses includes/Config.php to determine which templates are allowed. a “fallback” json represents the template, but if a TemplateData version is available it will prefer that.
* i have added the fallback json to the includes/Config.php and added you as a reviewer. once merged, it will appear on the beta cluster.
Comment 3 Jean-Fred 2014-02-15 16:02:00 UTC
Thanks Dan for the explanation − and the patch which I slightly amended. Looks good to me!

In the mean time I enabled TemplateData on {{Art Photo}} (isn't it possible to inherit it from {{Artwork}} & {{Photograph}}? would save some hassle).

I’m unsure of the results though − the API does not display anything though it should. See <https://commons.wikimedia.org/w/api.php?action=templatedata&format=jsonfm&titles=Template%3AArt_Photo>
Comment 4 Gerrit Notification Bot 2014-02-15 17:40:05 UTC
Change 113369 merged by Dan-nl:
add Art Photo template to GWToolset

https://gerrit.wikimedia.org/r/113369
Comment 5 David Haskiya 2014-03-18 16:08:10 UTC
Jean-Fred, this has been done. Do you want to close the ticket?
Comment 6 Jean-Fred 2014-03-18 16:09:06 UTC
Sure. Closed as fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links