Last modified: 2014-11-12 13:55:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63391, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61391 - Insert link item for adding language links in PHP
Insert link item for adding language links in PHP
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=0
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-14 19:30 UTC by Ori Livneh
Modified: 2014-11-12 13:55 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2014-02-14 19:30:58 UTC
Right now, the "Edit links" link in the languages pane of the sidebar is inserted via JavaScript after the page's contents have finished loading. There's good momentum at the moment behind moving all code that modifies the initial appearance of the page to PHP, because having parts of the interface be drawn and redrawn as the page is loading is slow and distracting.

The ability to add inter-language links in-place (that is, without navigating away from the page) requires that the user's browser supports CORS. Right now, the JavaScript code checks to see that the user's browser supports CORS. It will insert the link if the browser does support it, and not insert the link otherwise.  This particular check cannot be performed in PHP, so the alternative that I am proposing is that for users that do not have CORS support, clicking the link will trigger navigation to Wikidatawiki.

CORS support is at around 80% of global traffic, per <http://caniuse.com/cors>.

To be clear: if we make this change, the experience of 80% of users will not change. The impact will be scoped to the 20% of users that do not have CORS. They are currently not shown the "Edit links" link at all. If we make the change described above, they would be shown it, but instead of activating the in-place editing interface, it would cause them to navigate to Wikidatawiki.
Comment 1 Marius Hoch 2014-10-17 21:12:52 UTC
I think we at some point decided that such a non-JS link would be confusing and is essentially unwanted?
Comment 2 Gerrit Notification Bot 2014-10-24 18:20:20 UTC
Change 168632 had a related patch set uploaded by Hoo man:
[WIP] Create add links link in PHP

https://gerrit.wikimedia.org/r/168632

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links