Last modified: 2014-04-04 23:44:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63400, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61400 - Must click TWICE to toggle between desktop and mobile
Must click TWICE to toggle between desktop and mobile
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
: 63348 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-14 23:10 UTC by Juliusz Gonera
Modified: 2014-04-04 23:44 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Juliusz Gonera 2014-02-14 23:10:17 UTC
* Open a private browser window.
* Go to your local instance and click Mobile view.

The URL changes but the page stays in desktop mode. You have to manually refresh the page again. It's even worse on iOS where refreshing doesn't help, you have to go to the root URL again (http://127.0.0.1/).

Can't reproduce on enwiki.
Comment 1 Bingle 2014-02-18 18:34:26 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1708
Comment 2 Gerrit Notification Bot 2014-02-20 02:21:44 UTC
Change 114392 had a related patch set uploaded by Awjrichards:
Ensure checkToggleView() fires at appropriate time

https://gerrit.wikimedia.org/r/114392
Comment 3 Gerrit Notification Bot 2014-02-20 19:08:20 UTC
Change 114392 merged by jenkins-bot:
Ensure checkToggleView() fires at appropriate time

https://gerrit.wikimedia.org/r/114392
Comment 4 Arthur Richards 2014-02-20 19:29:07 UTC
Patch is merged, should now be resolved in master.
Comment 5 Arthur Richards 2014-02-28 23:28:46 UTC
We had to revert this change due to an edge-case production bug introduced (bug 62078). It should be trivial to resolve the problem but I need to consult with the Zero team about the change before implementing it, and no one is currently available so this will likely have to wait til next week to get resolved again.
Comment 6 dr0ptp4kt 2014-03-01 00:12:48 UTC
Email noted now that on IRC. Reviewing...
Comment 7 Max Semenik 2014-03-14 11:19:48 UTC
Reverted again. I declare this bug cursed! Let's NOT fix it.
Comment 8 Jon 2014-03-14 17:51:15 UTC
For the record, this change had to be reverted due to recursive errors. Reopening as we should probably work out what causes these recursive errors!
Comment 9 Dan Jacobson 2014-04-01 07:04:01 UTC
*** Bug 63348 has been marked as a duplicate of this bug. ***
Comment 10 Dan Jacobson 2014-04-01 07:06:33 UTC
Please fix soon. Major embarrassment on non-Wikimedia wikis!!
Comment 11 Dan Jacobson 2014-04-01 07:12:53 UTC
The perfect and instant solution would be for the "Mobile | Desktop"
links at the bottom of each page to link instead to just
useformat=mobile and useformat=desktop !!
Comment 12 Dan Jacobson 2014-04-03 05:30:00 UTC
I am not able to vote for this bug. You got to see it to believe it. http://abj.jidanni.org/ .
One might think of putting a siteNotice "Click twice to toggle moblie / desktop", but that's broken too, Bug 63457.
Comment 13 Dan Jacobson 2014-04-03 05:33:26 UTC
Maybe users can implement Comment 11 via some Hook as a workaround?
Comment 14 Andre Klapper 2014-04-03 07:26:49 UTC
[Prioritization is done by the Mobile team hence reverting; for severity meanings see https://www.mediawiki.org/wiki/Bugzilla/Fields#Severity ]
Comment 15 Gerrit Notification Bot 2014-04-03 17:43:30 UTC
Change 123678 had a related patch set uploaded by Awjrichards:
Ensure checkToggleView() fires at appropriate time

https://gerrit.wikimedia.org/r/123678
Comment 16 Gerrit Notification Bot 2014-04-03 19:00:58 UTC
Change 123678 merged by jenkins-bot:
Ensure checkToggleView() fires at appropriate time

https://gerrit.wikimedia.org/r/123678
Comment 17 Dan Jacobson 2014-04-04 01:17:54 UTC
Just curious how soon should I expect to see it?

cd /home/jidanni/mediawiki/extensions
+ git pull
From https://gerrit.wikimedia.org/r/p/mediawiki/core
   f1b45cb..49bc9d3  master     -> origin/master
   74ccd34..f935b80  wmf/1.23wmf21 -> origin/wmf/1.23wmf21
Updating f1b45cb..49bc9d3
Fast-forward
 includes/resourceloader/ResourceLoader.php |  59 ++++++++++++++++++++++---------------
 resources/oojs-ui/i18n/zh-hans.json        |   2 +-
 resources/oojs-ui/oojs-ui-apex.css         |   9 ++++--
 resources/oojs-ui/oojs-ui.js               | 118 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
 resources/oojs-ui/oojs-ui.svg.css          |   4 +--
 5 files changed, 154 insertions(+), 38 deletions(-)
Comment 18 Andre Klapper 2014-04-04 09:02:42 UTC
(In reply to Dan Jacobson from comment #17)
> Just curious how soon should I expect to see it?

https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap
Comment 19 Dan Jacobson 2014-04-04 23:30:20 UTC
I use https://gerrit.wikimedia.org/r/p/mediawiki/extensions/MobileFrontend.git

So that means at exactly one week after

group 0	Thursday, 3 April 2014	MediaWiki.org; testwiki; test2wiki; testwikidatawiki

I can use git pull and that will contain the change?
Comment 20 Jon 2014-04-04 23:44:37 UTC
If you are running your own MediaWiki install, yes simply pull down the latest code and you will have the fix instantly.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links