Last modified: 2014-03-04 02:09:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63410, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61410 - Jenkins unit tests for ParserFunctions should set $wgPFEnableStringFunctions = true;
Jenkins unit tests for ParserFunctions should set $wgPFEnableStringFunctions ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ParserFunctions (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Tony Thomas
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-15 02:56 UTC by Bawolff (Brian Wolff)
Modified: 2014-03-04 02:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2014-02-15 02:56:51 UTC
Jenkins runs unit tests without setting $wgPFEnableStringFunctions = true; This triggers all the parser tests for string functions to be skipped. Skipping all unit tests in a test suite cause the unit tests to fail.

02:41:51 
02:41:51 There was 1 failure:
02:41:51 
02:41:51 1) Warning
02:41:51 No tests found in suite "StringFunctionTests::testParserTest".
Comment 1 Gerrit Notification Bot 2014-02-18 12:11:50 UTC
Change 113945 had a related patch set uploaded by 01tonythomas:
Added the $wgPFEnableStringFunctions = true in ParserFunctions tests

https://gerrit.wikimedia.org/r/113945
Comment 2 Antoine "hashar" Musso (WMF) 2014-02-18 14:06:47 UTC
tonythomas01 / Gloria pinged me today and I suddenly remembered that our Jenkins job have a special global setting set when running jobs:

 $wgWikimediaJenkinsCI = true;

Using that, the ParserFunctions.php entry point can be hacked to set the $wgPFEnableStringFunctions global variable, i.e. something like:


 if ( $wgWikimediaJenkinsCI === true ) {
     $wgPFEnableStringFunctions = true;
 }
Comment 3 Gerrit Notification Bot 2014-02-18 14:13:15 UTC
Change 113945 merged by jenkins-bot:
Added the $wgPFEnableStringFunctions = true in ParserFunctions tests

https://gerrit.wikimedia.org/r/113945
Comment 4 Antoine "hashar" Musso (WMF) 2014-02-18 14:14:56 UTC
All parser tests are now being triggered AND they are passing \O/
Comment 5 MZMcBride 2014-03-04 00:01:15 UTC
Reverted in <https://gerrit.wikimedia.org/r/114937>?
Comment 6 Bawolff (Brian Wolff) 2014-03-04 02:09:48 UTC
Better approach would maybe to have phpunit set a define somewhere when running tests (if it doesnt already) and look for that

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links