Last modified: 2014-09-29 18:55:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63462, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61462 - SkinAfterBottomScripts doesn't run on mobile (Conflict with Google Analytics Integration extension)
SkinAfterBottomScripts doesn't run on mobile (Conflict with Google Analytics ...
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-17 14:02 UTC by Florian
Modified: 2014-09-29 18:55 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Florian 2014-02-17 14:02:49 UTC 
Referring to Bug https://bugzilla.wikimedia.org/show_bug.cgi?id=45622 it seems to that the Hook already not run on mobile. The Google Analytics Code does not appear in source code of mobile Webpage and the Site (unique identifier, md5 hash of a random string) does not show in Google Analytics account.

Tested on:
MW 1.23wmf11
PHP 5.3.3-7+squeeze18 (cgi-fcgi)
MySQL 5.1.73-1-log
MobileFrontend: Latest development build (beta)
tested Wiki: http://www.droidwiki.de/Spezial:Version

Tested with Google Chrome and UA switch to Android 4.0.3.
Comment 1 Bingle 2014-02-18 18:34:39 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1709
Comment 2 Gerrit Notification Bot 2014-02-20 23:24:48 UTC 
Change 114653 had a related patch set uploaded by MaxSem:
Ensure SkinAfterBottomScripts hook gets called

https://gerrit.wikimedia.org/r/114653
Comment 3 Florian 2014-02-21 07:09:06 UTC 
Applied Patch Codeline in used MobileFrontend copy (not loaded the entire Extension again). Tested the extension with same case->GA Script appers in Source code of page and page view is tracked by Google Analytics.

The patch seems to fix the problem. Thanks!
Comment 4 Gerrit Notification Bot 2014-02-25 20:22:16 UTC 
Change 114653 merged by jenkins-bot:
Ensure SkinAfterBottomScripts hook gets called

https://gerrit.wikimedia.org/r/114653
Comment 5 Gerrit Notification Bot 2014-09-19 14:26:44 UTC 
Change 161457 had a related patch set uploaded by Florianschmidtwelzow:
Allow invoking of SkinAfterBottomScripts

https://gerrit.wikimedia.org/r/161457
Comment 7 Jon 2014-09-25 21:53:19 UTC 
This is fixed on master so status shouldn't have changed.
Comment 8 Gerrit Notification Bot 2014-09-29 18:55:05 UTC 
Change 161457 merged by MaxSem:
Allow invoking of SkinAfterBottomScripts

https://gerrit.wikimedia.org/r/161457
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links