Last modified: 2014-04-08 15:46:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63464, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61464 - deleted page shows up in search results on Wikidata
deleted page shows up in search results on Wikidata
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: Chad H.
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-17 14:46 UTC by Lydia Pintscher
Modified: 2014-04-08 15:46 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
When the deleted page is restored, two results appear in the search page. (255.40 KB, image/png)
2014-03-07 03:45 UTC, Dan Garry
Details
All modifications to the restored page are ignored by the old result, except modifications to the description (272.34 KB, image/png)
2014-03-07 03:46 UTC, Dan Garry
Details

Description Lydia Pintscher 2014-02-17 14:46:50 UTC
A user on Wikidata reported that the item Q9028640 is still showing up in search results despite being deleted. https://www.wikidata.org/w/index.php?title=Special%3ASearch&profile=default&search=Q9028640&fulltext=Search

I don't know if it is just this one item or a larger issue.
Comment 1 Chad H. 2014-02-18 20:31:12 UTC
Most likely a Cirrus bug.
Comment 2 Chad H. 2014-03-05 21:11:21 UTC
I can't seem to replicate outside of the given example.

See for example Q15831339. https://www.wikidata.org/w/index.php?title=Special%3ASearch&profile=default&search=Q15831339&fulltext=Search shows no results, as expected.
Comment 3 Dan Garry 2014-03-07 03:45:30 UTC
Created attachment 14765 [details]
When the deleted page is restored, two results appear in the search page.
Comment 4 Dan Garry 2014-03-07 03:46:40 UTC
Created attachment 14766 [details]
All modifications to the restored page are ignored by the old result, except modifications to the description
Comment 5 Dan Garry 2014-03-07 04:36:11 UTC
I too am unable to replicate this bug outside the given example.

I attempted to restore and then redelete the page in question to see if this fixed the problem. It did not, but in fact exposed more strangeness.

If the deleted page is restored, two results appear when you search for the page instead of one. The first gives the current revision of the page, and the second buggy one is tied to a specific revision on 21 November 2013, which was the most recent revision before the page was deleted. See attachment 1 [details] for screenshot.

If the page is edited, then the information for the first entry updates, but the second one does not as it's tied to the out of date revision. Interestingly this applies to everything except the description, in which changes to this affect *both* versions of the page. See attachment 2 [details] for screenshot.

I'm still unsure what caused the page to still be indexed after it was deleted. Perhaps we should add some code somewhere to ensure that each page can have an entry in the index?
Comment 6 Dan Garry 2014-03-07 04:38:23 UTC
Oh dear, I didn't think Bugzilla would link like that. Obviously I meant attachment 14765 [details] and attachment 14766 [details], respectively.
Comment 7 Gerrit Notification Bot 2014-03-28 23:03:37 UTC
Change 121888 had a related patch set uploaded by Chad:
Protect against missing pages better

https://gerrit.wikimedia.org/r/121888
Comment 8 Gerrit Notification Bot 2014-03-28 23:31:00 UTC
Change 121888 merged by jenkins-bot:
Protect against missing pages better

https://gerrit.wikimedia.org/r/121888
Comment 9 Chad H. 2014-04-04 16:55:09 UTC
So we protect against this sort of thing better than before and we're more aggressive about reattempting failed deletions. I've never been able to run down a root cause of this bug (or really replicate it outside of the one instance).

If someone from Wikidata could take a look at this again and get an idea of the current status of the bug that would be great. Otherwise I'm inclined to close it as FIXED (it was a semi-freak occurrence that we've since protected against better)
Comment 10 Lydia Pintscher 2014-04-07 16:09:30 UTC
Feel free to close then. Thanks for investigating.
Comment 11 Chad H. 2014-04-08 15:46:01 UTC
Marking FIXED per above. Anyone please feel free to reopen if we find evidence of this again.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links