Last modified: 2014-04-25 06:11:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63472, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61472 - Message name appearing instead of message in dialogue presented when leaving edit window
Message name appearing instead of message in dialogue presented when leaving ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Normal normal (vote)
: 1.23.0 release
Assigned To: Fomafix
:
: 61478 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-18 03:37 UTC by Dan Garry
Modified: 2014-04-25 06:11 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
aklapper: Backport_WMF-


Attachments
Screenshot of error showing string name instead of string value (54.10 KB, image/png)
2014-02-18 03:37 UTC, Dan Garry
Details

Description Dan Garry 2014-02-18 03:37:10 UTC
Created attachment 14611 [details]
Screenshot of error showing string name instead of string value

1) Go to any page on mediawiki.org or en.wikipedia.org.
2) Open the edit page.
3) Make some changes to the article.
4) Try to navigate away without saving.

The message says "If you are logged in, you can disable this warning in the "[prefs-editing]" section of your preferences.", displaying the name of the string prefs-editing rather than its value (see attached screenshot).
Comment 1 Dan Garry 2014-02-18 03:44:54 UTC
This behaviour occurs in both Chrome and Safari on my computer (Mac OS X 10.9).

This doesn't occur in Firefox, but that's to be expected as Firefox overrides these custom messages with its own messages.
Comment 2 MZMcBride 2014-02-18 03:47:35 UTC
Localisation cache. This happens sometimes.
Comment 3 Bawolff (Brian Wolff) 2014-02-18 03:58:55 UTC
(In reply to MZMcBride from comment #2)
> Localisation cache. This happens sometimes.

I think it'd be more likely that Resource loader is caching a temporarily bad response from the localization cache rather then localization cache itself (This is idle speculation, I have no evidence)
Comment 4 Bawolff (Brian Wolff) 2014-02-18 04:04:23 UTC
Actually given timing, 64886d140e6ab3152 was recently merged (Jan 28). Since the message is going to JS, perhaps whatever magic parses messages on the js side simply doesn't support int:
Comment 5 Gerrit Notification Bot 2014-02-18 04:15:21 UTC
Change 113902 had a related patch set uploaded by Brian Wolff:
Revert "Transclude translation for preference edit section to ensure consistency of translation"

https://gerrit.wikimedia.org/r/113902
Comment 6 MZMcBride 2014-02-18 04:18:07 UTC
I suppose it would help if I fully read the bug report or glanced at the code before commenting. :-)

(In reply to Bawolff (Brian Wolff) from comment #4)
> Actually given timing, 64886d140e6ab3152 was recently merged (Jan 28). Since
> the message is going to JS, perhaps whatever magic parses messages on the js
> side simply doesn't support int:

Yeah, I think you're right.

From resources/mediawiki.action/mediawiki.action.edit.editWarning.js:

---
retval = mw.msg( 'editwarning-warning' )
---

From resources/mediawiki/mediawiki.js:

---
* If jqueryMsg is loaded, {{-transformation is done where supported
* (such as {{plural:}}, {{gender:}}, {{int:}}).
---

Bug 47840 mentions adding support for int: with parameters, but I believe basic int: support already exists... dunno.
Comment 7 Bartosz Dziewoński 2014-02-18 14:44:02 UTC
*** Bug 61478 has been marked as a duplicate of this bug. ***
Comment 8 Bartosz Dziewoński 2014-02-18 14:46:19 UTC
Fomafix's patch from bug 61478 appears to fix this. {{int:}} is supposed given that a) mediawiki.jqueryMsg module is loaded (which is not guaranteed now) and b) the message is made available to JavaScript (which it currently isn't).
Comment 9 Gerrit Notification Bot 2014-02-18 14:46:40 UTC
Change 113918 had a related patch set uploaded by Bartosz Dziewoński:
Parse {{int:...}} in editwarning

https://gerrit.wikimedia.org/r/113918
Comment 10 Bartosz Dziewoński 2014-02-18 14:58:15 UTC
(The patch above is of course by Fomafix, I only linked it to this bug.)

Given the visibility of the issue (at least two reports in a day), I think this could be backported to current WMF versions?
Comment 11 Gerrit Notification Bot 2014-02-18 15:00:43 UTC
Change 113918 merged by jenkins-bot:
Parse {{int:...}} in editwarning

https://gerrit.wikimedia.org/r/113918
Comment 12 Gerrit Notification Bot 2014-02-18 19:07:16 UTC
Change 113902 abandoned by Brian Wolff:
Revert "Transclude translation for preference edit section to ensure consistency of translation"

https://gerrit.wikimedia.org/r/113902

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links