Last modified: 2014-08-17 11:05:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63582, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61582 - Flow: browser test checks for post "1 second ago" but the test can display "3 seconds ago"
Flow: browser test checks for post "1 second ago" but the test can display "3...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-20 10:12 UTC by spage
Modified: 2014-08-17 11:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-02-20 10:12:15 UTC
flow_anon's "Add new Flow topic" wait_until 20 seconds to check
    page.text.include? "1 second ago" or page.text.include? "just now"
But computers can be slow; https://saucelabs.com/jobs/79f3dc0639f74c09a2f9640edd0d971d failed because the new topic showed "3 seconds ago".  Besides, the same test page can be simultaneously hit by other browsers, so some topic appearing recently doesn't test successful addition of this topic. 

The test should instead look for a topic titlebar (css: '.flow-topic-container .flow-titlebar' ) with a h2 matching the random number it just inserted, and within the titlebar it should accept '.flow-datestamp .flow-ago' containing "seconds ago" as well as "1 second ago" or "just now".
Comment 1 Gerrit Notification Bot 2014-03-22 05:43:19 UTC
Change 120189 had a related patch set uploaded by Spage:
Handle "N seconds ago" instead of dying

https://gerrit.wikimedia.org/r/120189
Comment 2 Gerrit Notification Bot 2014-03-22 05:47:13 UTC
Change 120189 merged by jenkins-bot:
Handle "N seconds ago" instead of dying

https://gerrit.wikimedia.org/r/120189
Comment 3 Andre Klapper 2014-07-09 09:16:01 UTC
All patches mentioned in this report are either merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 4 Andre Klapper 2014-08-17 11:05:45 UTC
No reply to comment 3 - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links