Last modified: 2014-03-10 22:31:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63584, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61584 - browser test "Given I am logged in" doesn't detect failure, must wait and check for success
browser test "Given I am logged in" doesn't detect failure, must wait and che...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Chris McMahon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-20 11:06 UTC by spage
Modified: 2014-03-10 22:31 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-02-20 11:06:17 UTC
The last Flow IE10 runs against beta labs failed "Create new topic logged in.Add new Flow topic".

The reported failure in https://wmf.ci.cloudbees.com/view/flow/job/Flow-en.wikipedia.beta.wmflabs.org-internet-explorer-10/157/testReport/%28root%29/Create%20new%20topic%20logged%20in/Add_new_Flow_topic/ is something about 
      And the talk and contrib links are not visible

But if you watch the screencast https://saucelabs.com/jobs/d4e55826d29841aea42661ff8acdbea7  , things have gone wrong long before this: the user is NOT logged in! The test has "Given I am logged in" and the test does fill in the login form, but the Flow page still shows "Log in" in the top right instead of "Selenium user", and the newly created topic is authored by an anonymous IP.

The mediawiki_selenium gem's login_with() function must actually check the page displayed after submission (usually the Main_Page) for a successful login and clearly report if login failed.  Currently it makes no checks to see if login succeeded.

As to how it failed, there doesn't seem to be any delay or waiting after visit(LoginPage).login_with(...) , so maybe the browser test jumped to visit FlowPage before the login page has gone through form submission, login to CentralAuth, redirect to login.wikimedia.org, setting loginwiki token cookie,  redirect back to some success page, etc. that give the browser the info to assert that it is logged in on the next page it visits.  I just did a beta labs login and it took 13 seconds, but the Sauce Labs movie jumped from the login form straight to the Flow page in less than a second.
Comment 1 Chris McMahon 2014-02-20 17:56:41 UTC
Agreed.  I noticed this had started happening recently for IE, and I added a check that the login completes to the shared login method with this commit:  https://gerrit.wikimedia.org/r/#/c/114096 

I believe that Flow is using the shared login. However, we need to update the gem to pick up this change.
Comment 2 Gerrit Notification Bot 2014-02-21 16:17:49 UTC
Change 114755 had a related patch set uploaded by Zfilipin:
Updated to the latest released version of mediawiki_selenium Ruby gem

https://gerrit.wikimedia.org/r/114755
Comment 3 Gerrit Notification Bot 2014-02-21 16:18:58 UTC
Change 114755 merged by Cmcmahon:
Updated to the latest released version of mediawiki_selenium Ruby gem

https://gerrit.wikimedia.org/r/114755
Comment 4 Željko Filipin 2014-03-03 14:14:07 UTC
Is this fixed?
Comment 5 Chris McMahon 2014-03-10 22:31:34 UTC
Should be resolved with the latest mediawiki_selenium gem

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links