Last modified: 2014-07-19 16:38:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63589, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61589 - CheckUser should pass jshint
CheckUser should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CheckUser (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Alex Monk
:
Depends on:
Blocks: jshint
  Show dependency tree / graph
 
Reported: 2014-02-20 13:25 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-07-19 16:38 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:25:48 UTC 
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-07-07 16:46:23 UTC 
Change 144473 had a related patch set uploaded by Alex Monk:
Clean up jslint errors

https://gerrit.wikimedia.org/r/144473
Comment 2 Gerrit Notification Bot 2014-07-19 14:59:20 UTC 
Change 144473 merged by jenkins-bot:
Clean up jslint errors

https://gerrit.wikimedia.org/r/144473
Comment 3 Alex Monk 2014-07-19 15:02:03 UTC 
Wtf? Somehow, when that patch was uploaded, we got:
https://integration.wikimedia.org/ci/job/mwext-CheckUser-jslint/56/console : SUCCESS in 8s (non-voting)
But then when merging:
https://integration.wikimedia.org/ci/job/mwext-CheckUser-jslint/57/console : FAILURE in 2s (non-voting)
Comment 4 Gerrit Notification Bot 2014-07-19 15:43:53 UTC 
Change 147744 had a related patch set uploaded by Alex Monk:
Reformat modules/ext.checkuser.cidr.js, fix some jshint errors

https://gerrit.wikimedia.org/r/147744
Comment 5 Gerrit Notification Bot 2014-07-19 16:04:28 UTC 
Change 147744 merged by jenkins-bot:
Reformat modules/ext.checkuser.cidr.js, fix some jshint errors

https://gerrit.wikimedia.org/r/147744
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links