Last modified: 2014-02-21 07:39:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63638, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61638 - TimedMediaHandler should pass jshint
TimedMediaHandler should pass jshint
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks: jshint
  Show dependency treegraph
 
Reported: 2014-02-20 13:50 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-02-21 07:39 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:50:21 UTC
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Bawolff (Brian Wolff) 2014-02-21 00:51:26 UTC
Rumour has it a big chunk of the js is going to be replaced with something from upstream sometime soonish. Should probably wait for that before wotying about this.
Comment 2 Antoine "hashar" Musso (WMF) 2014-02-21 07:22:20 UTC
If the Javascript code comes from upstream, one instruct jshint to ignore that code entirely by creating/editing .jshintignore
Comment 3 Michael Dale 2014-02-21 07:24:59 UTC
Upstream location: https://github.com/kaltura/mwEmbed/

Antoine, do you have link to the format of the jshitignore ? 

I don't think we would be against passing jshint upstream, but we certainly want to get things in sync first, then worry about jshint consistency.
Comment 4 Antoine "hashar" Musso (WMF) 2014-02-21 07:39:27 UTC
I guess the format is the usual one shell pattern per line :-D  Ie something like:

 /lib/3rdparty*
 /src/bugged.js

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links