Last modified: 2014-04-15 14:13:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63665, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61665 - Special:MergeItems error message should be improved
Special:MergeItems error message should be improved
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Low minor (vote)
: ---
Assigned To: karan
papercut
: easy, need-volunteer
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-20 15:26 UTC by Lydia Pintscher
Modified: 2014-04-15 14:13 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Lydia Pintscher 2014-02-20 15:26:02 UTC 
When there is an error on merging an item using Special:MergeItems it currently only shows you the API error message. Add a text before that error message saying something like "The items could not be merged. The following error occurred:".
Comment 1 Nandini Velam 2014-02-24 13:35:07 UTC 
I would like to work on this bug.Could u please assign this to me?
Comment 2 Tony Thomas 2014-02-24 13:36:04 UTC 
(In reply to Nandini Velam from comment #1)
> I would like to work on this bug.Could u please assign this to me?
Prepare the patch 
http://www.mediawiki.org/wiki/Gerrit/Tutorial
Comment 3 karan 2014-03-13 16:14:03 UTC 
Still, no patch has been created for the bug.
Could you please assign it to me. I want to work on it.
Comment 4 Tony Thomas 2014-03-13 16:28:47 UTC 
(In reply to karan from comment #3)
> Still, no patch has been created for the bug.
> Could you please assign it to me. I want to work on it.
Prepare the patch! Please note that getting the bug assigned is not necessary in submitting the patch.
Comment 5 Addshore 2014-03-22 21:40:57 UTC 
Just to correct the first description of this bug.
The bug does not lie in the API. The Api messages do not need to be changed as the SpecialPage does not get the messages from or infact use the API at all!

the bug instead lies on SpecialMergeitems on lines 156 ish
Thus the messages are in the ChangeOpsMerge class!
Comment 6 Gerrit Notification Bot 2014-03-22 22:52:47 UTC 
Change 120327 had a related patch set uploaded by Kushal124:
Improve error message for Special:MergeItems

https://gerrit.wikimedia.org/r/120327
Comment 7 Gerrit Notification Bot 2014-03-22 23:33:23 UTC 
Change 120327 merged by Addshore:
Improve error message for Special:MergeItems

https://gerrit.wikimedia.org/r/120327
Comment 8 Lydia Pintscher 2014-03-23 07:53:37 UTC 
Thanks for the patch Kushal!
Comment 9 Kushal Khandelwal 2014-03-23 07:57:20 UTC 
Lydia  Welcome :)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links