Last modified: 2014-02-20 15:51:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63666, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61666 - FlaggedRevs git master doesn't work in MediaWiki < 1.23
FlaggedRevs git master doesn't work in MediaWiki < 1.23
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
REL1_22-branch
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-20 15:32 UTC by Maarten Dammers
Modified: 2014-02-20 15:51 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Maarten Dammers 2014-02-20 15:32:09 UTC
In https://gerrit.wikimedia.org/r/103936 SpecialPage::getTitle was replaced with getPageTitle . getPageTitle was introduced in 1.23 breaking backward compatibility with 1.22 and lower (see https://doc.wikimedia.org/mediawiki-core/master/php/html/classSpecialPage.html#a04aacd5fbbe67c5d47fe76eab1f0e538)

So on my local wiki with 1.22.0 (6071399) + Flagged Revisions (ed2ea20)
21:41, 6 February 2014 (https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FFlaggedRevs.git/ed2ea203ee3c40b01db5af5d4249729fc3645a39) I get a nice error:

[b2c58233] /wiki/Special:AdvancedReviewLog Exception from line 376 of /data/var/www/html/w/includes/SpecialPage.php: Call to undefined method QualityOversight::getPageTitle

Backtrace:

#0 /data/var/www/html/w/extensions/FlaggedRevs/frontend/specialpages/reports/QualityOversight_body.php(75): SpecialPage->__call(string, array)
#1 /data/var/www/html/w/extensions/FlaggedRevs/frontend/specialpages/reports/QualityOversight_body.php(75): QualityOversight->getPageTitle()
#2 /data/var/www/html/w/extensions/FlaggedRevs/frontend/specialpages/reports/QualityOversight_body.php(51): QualityOversight->showForm()
#3 /data/var/www/html/w/includes/SpecialPage.php(631): QualityOversight->execute(NULL)
#4 /data/var/www/html/w/includes/SpecialPageFactory.php(488): SpecialPage->run(NULL)
#5 /data/var/www/html/w/includes/Wiki.php(298): SpecialPageFactory::executePath(Title, RequestContext)
#6 /data/var/www/html/w/includes/Wiki.php(602): MediaWiki->performRequest()
#7 /data/var/www/html/w/includes/Wiki.php(467): MediaWiki->main()
#8 /data/var/www/html/w/index.php(49): MediaWiki->run()
#9 {main}
Comment 1 Max Semenik 2014-02-20 15:35:23 UTC
It is a long-established tradition that master versions of most extensions are only compatible with master MW, so I see no problem here unless there's a specific pledge from  its developers to maintain backwards compatibility.
Comment 2 Maarten Dammers 2014-02-20 15:37:29 UTC
I agree Max, but check out https://www.mediawiki.org/wiki/MediaWiki . The current stable release of mediawiki is 1.22.2. We should at least support that.
Comment 3 Max Semenik 2014-02-20 15:47:05 UTC
And there's LTS 1.19 which is also supported. But you should use respective branches for them.
Comment 4 Andre Klapper 2014-02-20 15:51:01 UTC
(In reply to Maarten Dammers from comment #0)
> So on my local wiki with 1.22.0 (6071399) + Flagged Revisions (ed2ea20)

But ed2ea20 is git master, it seems. You filed this ticket against FlaggedRevs and set the version field to "REL1_22 branch" which is confusing.

For MediaWiki 1.22, the FlaggedRevs "REL1_22" branch is meant to be used.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links