Last modified: 2014-02-20 23:25:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63698, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61698 - Remove enum constraint from Schema:Echo
Remove enum constraint from Schema:Echo
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-20 19:30 UTC by Dario Taraborelli
Modified: 2014-02-20 23:25 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dario Taraborelli 2014-02-20 19:30:00 UTC
Given that notifications are in the wild and arbitrary notification types can now be added, it makes no sense to maintain a fixed schema with a limited number of valid types any longer.

The existing enum is already breaking validation for legitimate events generated by Flow. I modified Schema:Echo and removed the enum so we can recover these missing events [1]

However, this approach is not going to be viable in the long term. As with campaigns, we will need to replace the current dashboards and data processing scripts (which assume a fixed schema) with something more flexible.

[1] https://meta.wikimedia.org/w/index.php?title=Schema%3AEcho&diff=7572295&oldid=6081131
Comment 1 Dario Taraborelli 2014-02-20 19:33:42 UTC
https://bugzilla.wikimedia.org/show_bug.cgi?id=60555
Comment 2 Gerrit Notification Bot 2014-02-20 22:41:34 UTC
Change 114638 had a related patch set uploaded by Ori.livneh:
Update Schema:Echo revision to r7572295

https://gerrit.wikimedia.org/r/114638
Comment 3 Gerrit Notification Bot 2014-02-20 22:44:48 UTC
Change 114638 merged by Swalling:
Update Schema:Echo revision to r7572295

https://gerrit.wikimedia.org/r/114638
Comment 4 Ori Livneh 2014-02-20 22:55:43 UTC
Deployed.
Comment 5 Gerrit Notification Bot 2014-02-20 23:12:31 UTC
Change 114650 had a related patch set uploaded by Legoktm:
Update Schema:Echo to revision 7572295

https://gerrit.wikimedia.org/r/114650
Comment 6 Gerrit Notification Bot 2014-02-20 23:22:08 UTC
Change 114650 merged by Ori.livneh:
Update Schema:Echo to revision 7572295

https://gerrit.wikimedia.org/r/114650
Comment 7 Kunal Mehta (Legoktm) 2014-02-20 23:25:00 UTC
[03:22:59 PM]  <+logmsgbot>	 !log ori synchronized wmf-config/CommonSettings.php  'I62011ada8: Update Schema:Echo to revision 7572295'

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links