Last modified: 2014-02-20 23:25:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63709, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61709 - wgMFAutodetectMobileView results in fatal
wgMFAutodetectMobileView results in fatal
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-20 22:33 UTC by Arthur Richards
Modified: 2014-02-20 23:25 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Arthur Richards 2014-02-20 22:33:30 UTC
Against current master with $wgMFAutodetectMobileView = true in LocalSettings, I get a fatal error when trying to load my local site in a state that should induce the mobile view:

Original exception: [f2672a8a] /testing/core/index.php/Main_Page Exception from line 201 of /mnt/hgfs/wikimedia_git/extensions/MobileFrontend/includes/DeviceDetection.php: PredefinedDeviceProperties::isTablet() called!
Backtrace:
#0 /mnt/hgfs/wikimedia_git/extensions/MobileFrontend/includes/MobileContext.php(133): PredefinedDeviceProperties->isTablet()
#1 /mnt/hgfs/wikimedia_git/extensions/MobileFrontend/includes/MobileContext.php(361): MobileContext->isMobileDevice()
#2 /mnt/hgfs/wikimedia_git/extensions/MobileFrontend/includes/MobileContext.php(279): MobileContext->shouldDisplayMobileViewInternal()
#3 /mnt/hgfs/wikimedia_git/extensions/MobileFrontend/includes/MobileFrontend.hooks.php(785): MobileContext->shouldDisplayMobileView()
#4 [internal function]: MobileFrontendHooks::onOutputPageParserOutput(OutputPage, ParserOutput)
#5 /mnt/hgfs/testing/core/includes/Hooks.php(206): call_user_func_array(string, array)
#6 /mnt/hgfs/testing/core/includes/GlobalFunctions.php(4008): Hooks::run(string, array, NULL)
#7 /mnt/hgfs/testing/core/includes/OutputPage.php(1605): wfRunHooks(string, array)
#8 /mnt/hgfs/testing/core/includes/OutputPage.php(1614): OutputPage->addParserOutputNoText(ParserOutput)
#9 /mnt/hgfs/testing/core/includes/Article.php(630): OutputPage->addParserOutput(ParserOutput)
#10 /mnt/hgfs/testing/core/includes/actions/ViewAction.php(44): Article->view()
#11 /mnt/hgfs/testing/core/includes/Wiki.php(428): ViewAction->show()
#12 /mnt/hgfs/testing/core/includes/Wiki.php(292): MediaWiki->performAction(Article, Title)
#13 /mnt/hgfs/testing/core/includes/Wiki.php(586): MediaWiki->performRequest()
#14 /mnt/hgfs/testing/core/includes/Wiki.php(447): MediaWiki->main()
#15 /mnt/hgfs/testing/core/index.php(49): MediaWiki->run()
#16 {main}
Comment 1 Bingle 2014-02-20 22:40:08 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1713
Comment 2 Ryan Kaldari 2014-02-20 22:58:33 UTC
Fixed in https://gerrit.wikimedia.org/r/#/c/114640/
Comment 3 Arthur Richards 2014-02-20 23:23:56 UTC
Kaldari, that patchset is for an unrelated problem (bug 61707) and doesn't actually resolve this :)
Comment 4 Arthur Richards 2014-02-20 23:25:10 UTC
Er actually, I take that back - I should have tested before I said that. Apparently your patch does fix this seemingly unrelated problem!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links