Last modified: 2014-04-10 02:36:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63725, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61725 - Flow: Interlanguage links are losing the :colon prefix when saved
Flow: Interlanguage links are losing the :colon prefix when saved
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-21 01:01 UTC by Quiddity
Modified: 2014-04-10 02:36 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quiddity 2014-02-21 01:01:53 UTC
If I type this in a post:
 [[:en:Foo bar]]
it gets saved as:
 [[en:Foo bar]]

It should preserve the :colon prefix.


[Further detail. Possibly a separate bug, or it's an intended effect?]

If I then edit that post, and just add ", true" after the link, it gets saved as:
 [[http://en.wikipedia.org/wiki/Foo bar]], true
which renders as
 , true
Eg https://www.mediawiki.org/w/index.php?title=Talk:Flow_QA&topic_newRevision=rplry5w6txhfutf1&topic_oldRevision=rplrxf88a3ptg6wp&workflow=rplqjkun4mxieeac&action=compare-revisions
Comment 1 Quiddity 2014-02-21 01:21:10 UTC
Possibly related to Parsoid's bug 51442 ?
Comment 2 Erik Bernhardson 2014-02-21 19:11:02 UTC
on second look..this may be parsoid related but not entirely sure.

Using the round trip form ( http://parsoid.wmflabs.org/_rtform/ ) this looks to work correctly.

On the other hand manually round tripping at http://parsoid.wmflabs.org/_wikitext/:

    [[:en:Foo bar]]

results

    <p data-parsoid='{"dsr":[0,15,0,0]}'><a rel="mw:ExtLink" href="http://en.wikipedia.org/wiki/Foo%20bar" data-parsoid='{"stx":"simple","a":{"href":"http://en.wikipedia.org/wiki/Foo bar"},"sa":{"href":":en:Foo bar"},"isIW":true,"dsr":[0,15,2,2]}'>en:Foo bar</a></p>

Which when provided to http://parsoid.wmflabs.org/_html/ gives me back:

    [[en:Foo bar]]
Comment 3 Quiddity 2014-04-07 23:13:48 UTC
Getting stranger. This bug now only seems to affect certain interwiki links. fr: confirmed.

Detail:
When I add "[:fr:Athérure]" it gets saved as "[fr:Athérure]", and then if I edit the post again it gets saved as "[http://fr.wikipedia.org/wiki/Athérure]"

But if I add "[:de:Zufall]" it gets correctly saved as "[:de:Zufall]"

Test case here: https://www.mediawiki.org/w/index.php?title=Talk:Sandbox&topic_postId=rsg1m81vskkdywgk&workflow=rsftpxbkjdg745zu#flow-post-rsg1m81vskkdywgk

and another editor battling the problem here: https://www.mediawiki.org/w/index.php?title=Talk:Beta_Features/Hovercards&topic_postId=rs2kexhb014dx2d8&workflow=rs2kexh7vs938oxo&action=history


(Possibly this bug should be reassigned to Parsoid?)
Comment 4 spage 2014-04-10 02:36:57 UTC
I think the accents in [[:fr:Athérure]]  and [[:fr:Porc-épic]] are the key. [[:en:Foo bar]] now works, it preserves the leading colon.

To reproduce in Parsoid, copy the following three lines:

[[:fr:Athérure]] and [[:fr:Porc-épic]] lose the leading colon.
May be it's the accent since [[:fr:Bonjour]] is OK.
[[:en:Foo bar]] used to not work...

If you send it through http://parsoid.wmflabs.org/_rtform/ , it claims the resulting wikitext is identical.

But in Flow, if you put this in a post, then when you later edit this post, the leading colon from the accented links is gone from the wikitext.

The API call Flow makes is

https://www.mediawiki.org/w/api.php?action=query&format=json&list=flow&flowpage=Talk%3ASandbox&flowworkflow=rsftpxbkjdg745zu&flowparams={%22topic%22%3A{%22postId%22%3A%22rskn5smwrffhalus%22%2C%22contentFormat%22:%22wikitext%22}}

which makes Flow ask Parsoid to convert the HTML to wikitext, and the accented links have lost the leading colon.

parsoid interwiki links was recently changed, gerrit I86024ff038

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links