Last modified: 2014-04-15 06:27:25 UTC
https://noc.wikimedia.org/conf/wikiversions.json currently reads (in part): --- { "aawiki": "php-1.23wmf14", "aawikibooks": "php-1.23wmf14", "aawiktionary": "php-1.23wmf14", "abwiki": "php-1.23wmf14", --- The "php-" part seems unnecessary and can probably be (carefully) removed. Or perhaps replaced with "mw-".
(In reply to MZMcBride from comment #0) > The "php-" part seems unnecessary and can probably be (carefully) removed. > Or perhaps replaced with "mw-". Decisions, decisions
The php- prefix is hardcoded everywhere. There is no reason for us to invest time in fixing every possible occurrences or handle back compatibility code around.
(In reply to Antoine "hashar" Musso from comment #2) > The php- prefix is hardcoded everywhere. This is hyperbole. Please don't be hasty.
What is the advantage / gain of removing it?
The values in the wikiversions.json and compiled wikiversions.cdb files are the directory names used for the branch checkouts relative to the /usr/local/apache/common directory on each apache server. It is hardcoded in at least these locations in operations/mediawiki-config.git: * .gitignore * logmsg-git-hook * multiversion/activeMWVersions.php * multiversion/checkoutMediaWiki.php * multiversion/deleteMediaWiki * multiversion/MWMultiVersion.php * multiversion/updateBitsBranchPointers * multiversion/updateWikiversions.php * wmf-config/StartProfiler.php There is also hard coded knowledge of this prefix in both the legacy scap scripts and the new python code.
Bryan see my comment #2 above. I dont think we should spend time dropping that prefix.
(In reply to Andre Klapper from comment #4) > What is the advantage / gain of removing it? It looks silly. wikiversions.json includes "php-1.23wmf14". There's probably a good historical reason for this, but I don't think it needs to linger indefinitely. I think "mw-1.23wmf14" or "1.23wmf14" would be clearer, but perhaps as hashar suggests, this isn't worth the effort to change.
