Last modified: 2014-03-04 13:07:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63749, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61749 - viewing a diff does not show the latest revision below the diff
viewing a diff does not show the latest revision below the diff
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
backlog
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-21 14:53 UTC by Lydia Pintscher
Modified: 2014-03-04 13:07 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lydia Pintscher 2014-02-21 14:53:58 UTC
View a diff link showing the diff since a specific old revision. Below it the old version is shown, not the current one. The opposite happens for diffs between two specific revisions.
Comment 1 Thiemo Mättig 2014-02-21 17:29:57 UTC
I fail to reproduce this. Do you have a few example URLs?
Comment 3 Thiemo Mättig 2014-02-24 10:43:06 UTC
(In reply to Lydia Pintscher from comment #2)
> https://www.wikidata.org/w/?title=Q5089124&diff=0&oldid=97248895
> is one.

Huh, where does the diff=0 come from? Do you typed this? https://www.wikidata.org/w/?title=Q5089124&diff=cur&oldid=97248895 does work as expected.

The core code that checks and parses the diff and oldid parameters is a bit strange. There is no comparison with a constant "cur" in core. Instead it checks for "prev", "next" and numbers and treads everything else (even an empty ...&diff&... with no equal sign) as "cur". Example: https://www.wikidata.org/w/?diff&oldid=104570626

For some reason all this does not work in Wikibase. In my opinion it should be made the same.
Comment 4 Lydia Pintscher 2014-02-24 17:57:17 UTC
diff=0 compares to whatever is the newest revision. It is in email notifications for changes for example.
Comment 5 Gerrit Notification Bot 2014-02-24 22:09:50 UTC
Change 115310 had a related patch set uploaded by Thiemo Mättig (WMDE):
Wikibase parsing of diff=... parameter was different from core

https://gerrit.wikimedia.org/r/115310
Comment 6 Gerrit Notification Bot 2014-02-28 09:09:11 UTC
Change 115310 merged by jenkins-bot:
Wikibase parsing of diff=... parameter was different from core

https://gerrit.wikimedia.org/r/115310

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links