Last modified: 2014-03-27 20:04:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63752, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61752 - Beta search provides weird snippets from JS pages
Beta search provides weird snippets from JS pages
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: Highest critical (vote)
: ---
Assigned To: Chad H.
https://pt.wikibooks.org/wiki/Special...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-21 16:25 UTC by Helder
Modified: 2014-03-27 20:04 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Search results for "mw prefix:Utilizador:H" on ptwikibooks (145.24 KB, image/png)
2014-02-21 16:25 UTC, Helder
Details

Description Helder 2014-02-21 16:25:55 UTC
Created attachment 14649 [details]
Search results for "mw prefix:Utilizador:H" on ptwikibooks

Just look at the screenshot. Something is wrong.
Comment 1 Chad H. 2014-02-22 02:41:22 UTC
Confirmed this earlier today after chatting with some people. This is really bad.

Here's what we're pretty sure is happening (need to confirm that):
- Cirrus is parsing the JS page even though it shouldn't.
- Since it's being treated as wikitext and being parsed, we're getting weird results when we hit a header tag in Javascript (in this case, no parseable closing tag)
- We generate bogus sections as a result that shouldn't go anywhere

We should (in no particular order):
- Check content handling to make sure CSS/JS pages aren't getting parsed like wikitext
- Make sure core Special:Search is not being insane when given obviously bogus sections. See also bug 59717 where lsearchd is giving us bogus section titles as well

There's a second bug (but might just be a symptom of this bug) in that we see two distinct titles (vector.js and Tools.js) but they've got the same section name (which only exists in the former).
Comment 2 Gerrit Notification Bot 2014-02-24 19:14:34 UTC
Change 115214 had a related patch set uploaded by Chad:
Don't use parsed wikitext when dealing with CSS/JS pages

https://gerrit.wikimedia.org/r/115214
Comment 3 Gerrit Notification Bot 2014-02-24 23:37:27 UTC
Change 115214 merged by jenkins-bot:
Don't use parsed wikitext when dealing with CSS/JS

https://gerrit.wikimedia.org/r/115214
Comment 4 Chad H. 2014-02-24 23:38:49 UTC
Will go out with next deploy cycle and results will still be wonky until indexes are rebuilt.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links