Last modified: 2014-03-12 12:54:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63793, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61793 - Special:ApiSandbox JavaScript error if API module doesn't supply parameters
Special:ApiSandbox JavaScript error if API module doesn't supply parameters
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ApiSandbox (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-22 05:03 UTC by spage
Modified: 2014-03-12 12:54 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-02-22 05:03:05 UTC 
https://gerrit.wikimedia.org/r/#/c/111255/1 is work in progress for a new API.  It works: api.php?action=query&prop=flow&titles=Talk:Main_Page returns something. However, because this API module doesn't implement getAllowedParams() and getParamDescription(), Special:ApiSandbox has errors if you try to invoke it. If I choose action=query, prop=flow, "Loading..." spins forever, the [Make Request] button remains disabled, and the browser console shows the error

   TypeError: this.params is undefined http://localhost/wiki/extensions/ApiSandbox/resources/UiBuilder.js Line 62

The fix is for ApiSandbox's JS to handle an absent parameters list. It would be nice if it warned "<modulename> does not supply allowed parameters".
Comment 1 Gerrit Notification Bot 2014-02-22 06:12:40 UTC 
Change 114916 had a related patch set uploaded by Spage:
Handle API module with no parameters

https://gerrit.wikimedia.org/r/114916
Comment 2 Gerrit Notification Bot 2014-03-05 20:11:48 UTC 
Change 114916 merged by jenkins-bot:
Handle API module with no parameters

https://gerrit.wikimedia.org/r/114916
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links