Last modified: 2014-03-06 23:25:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63797, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61797 - Flow: don't log exceptions for expected "Interwiki to somewiki not implemented" errors
Flow: don't log exceptions for expected "Interwiki to somewiki not implemente...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-22 08:00 UTC by spage
Modified: 2014-03-06 23:25 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-02-22 08:00:11 UTC
The known Flow "Interwiki to somewiki not implemented" exception is generating a lot of exception.log entries. it was about 95% of exceptions today and is skewing our exceptions+fatals graphing.  About 85% of the log entries originate on metawiki.  There's no user-facing error from these, so Flow should just wfLogWarning() or do nothing when this is the exception, rather than call
  \MWExceptionHandler::logException( $e )

The code is includes/Formatter/ContributionsQuery.php line 116 in 1.23wmf15, it moved since 1.23wmf14.

2014-02-22 07:11:30 mw1036 metawiki: [43691a42] /wiki/Special:Contributions/<SomeUser>   Exception from line 99 of /usr/local/apache/common-local/php-1.23wmf14/extensions/Flow/includes/Model/Workflow.php: Interwiki to mediawikiwiki not implemented
Comment 1 Gerrit Notification Bot 2014-02-25 00:14:14 UTC
Change 115322 had a related patch set uploaded by Bsitu:
Do not log expected Flow exceptions

https://gerrit.wikimedia.org/r/115322
Comment 2 Gerrit Notification Bot 2014-02-25 00:15:15 UTC
Change 115322 merged by jenkins-bot:
Do not log expected Flow exceptions

https://gerrit.wikimedia.org/r/115322
Comment 3 Gerrit Notification Bot 2014-02-25 19:58:43 UTC
Change 115430 had a related patch set uploaded by EBernhardson:
Do not log expected Flow exceptions

https://gerrit.wikimedia.org/r/115430
Comment 4 Gerrit Notification Bot 2014-02-25 20:00:56 UTC
Change 115430 merged by jenkins-bot:
Do not log expected Flow exceptions

https://gerrit.wikimedia.org/r/115430
Comment 5 spage 2014-03-04 03:00:37 UTC
It isn't fixed! 5000 of these exceptions in the past 18 hours :-( All from

2014-03-03 08:40:37 mw1099 metawiki: [616cc4cf] /wiki/Special:Contributions/SomeUserNameHere   Exception from line 165 of /usr/local/apache/common-local/php-1.23wmf15/extensions/Flow/includes/Model/Workflow.php: Interwiki to enwiki not implemented 

The Gerrit changes above were to not log the exception in Formatter/Contributions.php , but as I wrote in comment 0, it's coming from Contributions*QUERY*.php, a different file:

#0 /usr/local/apache/common-local/php-1.23wmf15/extensions/Flow/includes/Formatter/ContributionsQuery.php(220): Flow\Model\Workflow->getArticleTitle()
#1 /usr/local/apache/common-local/php-1.23wmf15/extensions/Flow/includes/Formatter/ContributionsQuery.php(113): Flow\Formatter\ContributionsQuery->buildResult(Object(ContribsPager), Object(Flow\Model\PostRevision), 'topic')
...
Comment 6 spage 2014-03-04 23:04:28 UTC
Gerrit change I1a16348c2b03b comments out the other LogException site, we're backporting it to wmf15 and 16
Comment 7 spage 2014-03-06 23:25:53 UTC
No exceptions with this since the second backport.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links