Last modified: 2014-07-17 11:42:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63848, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61848 - FlaggablePageTest::testPageDataFromTitle: SqlBagOStuff::set: Flushing an explicit transaction, getting out of sync! [Called from DatabaseBase::commit in ...
FlaggablePageTest::testPageDataFromTitle: SqlBagOStuff::set: Flushing an expl...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-24 12:04 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-07-17 11:42 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-02-24 12:04:21 UTC
I have added Jenkins job for the FlaggedRevs extension (bug 59918) and created a dummy change https://gerrit.wikimedia.org/r/#/c/115143/

The test suite does not pass because FlaggablePageTest::testPageDataFromTitle triggers an uncommitted transaction.

See attached build log coming from https://integration.wikimedia.org/ci/job/mwext-FlaggedRevs-testextensions-master/1/console
Comment 1 Gerrit Notification Bot 2014-02-24 12:06:56 UTC
Change 115147 had a related patch set uploaded by Hashar:
mwext-FlaggedRevs-testextensions-master is not passing

https://gerrit.wikimedia.org/r/115147
Comment 2 Gerrit Notification Bot 2014-02-24 12:07:28 UTC
Change 115147 merged by jenkins-bot:
mwext-FlaggedRevs-testextensions-master is not passing

https://gerrit.wikimedia.org/r/115147
Comment 3 Antoine "hashar" Musso (WMF) 2014-02-24 13:25:54 UTC
The job is being run by Gerrit/Zuul but is not blocking changes pending the test suite to be fixed.
Comment 4 Brad Jorsch 2014-06-11 17:43:14 UTC
Glancing through the code, it appears that when sqlite is being used for both the main database and SqlBagOStuff, it will use the same database connection for both. So when SqlBagOStuff as $wgMemc flushes the database transaction, it is interfering with the transactions on the main database as well, giving this error.

MySQL has a different code path in SqlBagOStuff::getDB that appears to create an entirely new loadbalancer object which will return a separate database connection, causing no interference in production.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links