Last modified: 2014-04-23 11:54:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63854, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 61854 - Don't link deleted items in the UI


Summary:	Don't link deleted items in the UI

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High critical (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:	u=dev c=backend p=13
Keywords:

Depends on:	62724
Blocks:
	Show dependency tree / graph

Reported:	2014-02-24 16:54 UTC by tobias.gritschacher
Modified:	2014-04-23 11:54 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description tobias.gritschacher 2014-02-24 16:54:26 UTC

If an item that is referenced in a claim of another item gets deleted, it is still shown as a link in that item. Instead it should be not linked and shown with a hint "deleted item".
This functionality broke (possibly) during the introduction of backend formatters for items.

Comment 1 Adrian Lang 2014-03-07 14:13:28 UTC

This is a backend issue, since the frontend does not do any formatting on its own anymore.

Comment 2 Daniel Kinzler 2014-03-14 14:03:02 UTC

The problem is doing this without asking the database about each link individually. We'll need to refactor EntityIdHtmlLinkFormatter and related classes so they can take information about the existance of an item (and also its link and description) from a service that encapsulates the required batch query logic.

Comment 3 Gerrit Notification Bot 2014-03-31 11:24:24 UTC

Change 117424 had a related patch set uploaded by Thiemo Mättig (WMDE):
[WIP] Properly red-link deleted properties and items

https://gerrit.wikimedia.org/r/117424

Comment 4 Gerrit Notification Bot 2014-04-14 20:47:36 UTC

Change 125874 had a related patch set uploaded by Thiemo Mättig (WMDE):
Render links to deleted items in red

https://gerrit.wikimedia.org/r/125874

Comment 5 Gerrit Notification Bot 2014-04-15 14:24:36 UTC

Change 125874 merged by jenkins-bot:
Render links to deleted items in red

https://gerrit.wikimedia.org/r/125874

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links