Last modified: 2014-02-28 00:16:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63864, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61864 - VisualEditor: Disable the redirect input field unless the checkbox is checked
VisualEditor: Disable the redirect input field unless the checkbox is checked
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High minor
: VE-deploy-2014-02-27
Assigned To: James Forrester
:
: 61866 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-24 19:42 UTC by WhatamIdoing
Modified: 2014-02-28 00:16 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-02-24 19:42:50 UTC
In the "Page settings" dialog, it says "Redirect this page to" and a blank field for the target name.  If you put a name in there, then it sets a redirect, even if you don't tick the checkbox.  

VisualEditor should automatically tick the checkbox there if it's going to set a redirect (e.g., as soon as you start typing).  Otherwise, it looks like it's not going to redirect the page when you exit the dialog box.

(Reproducing this has only been consistent if there is no redirect on the page at the start of the editing session.)
Comment 1 James Forrester 2014-02-24 20:06:20 UTC
The logic for this box is meant to work the other way around - that is, you can't set a redirect unless you check the box first - but a simple forgotten line made this not work in one (very frequent) case: when the page isn't a redirect and you're making it one. Whoops. :-(
Comment 2 James Forrester 2014-02-24 20:06:33 UTC
*** Bug 61866 has been marked as a duplicate of this bug. ***
Comment 3 Gerrit Notification Bot 2014-02-24 20:10:01 UTC
Change 115237 had a related patch set uploaded by Jforrester:
Disable redirect field unless the checkbox is set in setup

https://gerrit.wikimedia.org/r/115237
Comment 4 Gerrit Notification Bot 2014-02-24 22:07:41 UTC
Change 115237 merged by jenkins-bot:
Disable redirect field unless the checkbox is set in setup

https://gerrit.wikimedia.org/r/115237
Comment 5 Rummana Yasmeen 2014-02-28 00:16:54 UTC
verified the fix in betalabs:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Imageghau

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links