Last modified: 2014-03-21 02:50:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63888, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61888 - Adjust RSS whitelist for mediawiki.org (mediawikiwiki)
Adjust RSS whitelist for mediawiki.org (mediawikiwiki)
Status: PATCH_TO_REVIEW
Product: Wikimedia
Classification: Unclassified
Extension setup (Other open bugs)
wmf-deployment
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-25 02:21 UTC by MZMcBride
Modified: 2014-03-21 02:50 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2014-02-25 02:21:25 UTC
[[mw:Extension:RSS]] has a configurable whitelist. It currently includes https://blog.wikimedia.org/feed/ for mediawikiwiki, but this directive doesn't allow feeds such as https://blog.wikimedia.org/c/technology/mediawiki/feed/ to be included.

Current configuration from <https://noc.wikimedia.org/conf/InitialiseSettings.php.txt>:

---
	'mediawikiwiki' => array(
'http://blog.wikimedia.org/feed/',
'https://git.wikimedia.org/feed/mediawiki/extensions/Translate.git',
'https://mingle.corp.wikimedia.org/projects/analytics/feeds/8z8k6vUfniLmWc2qGe6GMQsxBujvKRKuybLd8mdTbMFHwGfLH3oxK*MU0E8zM6go.atom',
	),
---

We should either add https://blog.wikimedia.org/c/technology/mediawiki/feed/ explicitly or whitelist all of https://blog.wikimedia.org/ (preferable).
Comment 1 Andre Klapper 2014-02-25 12:23:50 UTC
As this is marked as "easy" in combination with "shell" (which is not recommended according to the keyword description): 
Where would a patch contributor find the file to edit in Git?
Comment 2 Bawolff (Brian Wolff) 2014-02-25 19:16:42 UTC
(In reply to Andre Klapper from comment #1)
> As this is marked as "easy" in combination with "shell" (which is not
> recommended according to the keyword description): 
> Where would a patch contributor find the file to edit in Git?

Its in the operations/mediawiki-config repo.

The no easy+shell thing should perhaps be reconsidered now that those files are in git and anyone can submit a patch. Historically it required someone with actual shell access.
Comment 3 Gerrit Notification Bot 2014-03-16 06:15:22 UTC
Change 118956 had a related patch set uploaded by 01tonythomas:
Adjust RSS whitelist to allow mediawiki blog feeds

https://gerrit.wikimedia.org/r/118956
Comment 4 Bawolff (Brian Wolff) 2014-03-21 02:50:49 UTC
> explicitly or whitelist all of https://blog.wikimedia.org/ (preferable).

It appears that requires code changes to RSS extension...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links