Last modified: 2014-02-26 01:07:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63928, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61928 - Crasher in serializer with templated image parameters
Crasher in serializer with templated image parameters
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-25 20:32 UTC by Gabriel Wicke
Modified: 2014-02-26 01:07 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2014-02-25 20:32:28 UTC 
Example issue:
http://parsoid.wmflabs.org:8001/result/ea33a1daa87e0fa9a4e97a2997c5e9683a6c3cb8/plwiki/Pa%C5%84stwa_%C5%9Bwiata

When serializing a link, the serializer encounters an error:
TypeError: Cannot read property 'href' of undefined
    at TagTk.genericTokenMethods.getAttributeShadowInfo (/home/gabriel/src/parsoid/lib/mediawiki.parser.defines.js:170:24)

This seems to be caused by a missing ta entry.

A bisection suggests that commit 83b0de03 is to blame.
Comment 1 Gerrit Notification Bot 2014-02-26 00:47:06 UTC 
Change 115551 had a related patch set uploaded by Subramanya Sastry:
(Bug 61928) Fix WTS to recognize templated attrs in inline images.

https://gerrit.wikimedia.org/r/115551
Comment 2 Gerrit Notification Bot 2014-02-26 00:53:01 UTC 
Change 115551 merged by jenkins-bot:
(Bug 61928) Fix WTS to recognize templated attrs in inline images.

https://gerrit.wikimedia.org/r/115551
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links