Last modified: 2014-07-16 21:57:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63940, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61940 - Remove text shadow from default mediawiki.ui buttons
Remove text shadow from default mediawiki.ui buttons
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Moiz Syed
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-26 02:02 UTC by Steven Walling
Modified: 2014-07-16 21:57 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Steven Walling 2014-02-26 02:02:35 UTC 
The default mediawiki.ui button style (see guide: http://tools.wmflabs.org/styleguide/desktop/section-2.html) has text-shadow: 0 1px rgba(0,0,0,.1);

This makes the text of the button look blurry and is less readable.
Comment 1 Jared Zimmerman (WMF) 2014-02-26 03:42:15 UTC 
I disagree
Comment 2 Steven Walling 2014-02-26 19:54:44 UTC 
(In reply to Jared Zimmerman (WMF) from comment #1)
> I disagree

We can work this out in a mediawiki.ui hack day.
Comment 3 Jared Zimmerman (WMF) 2014-03-17 18:31:42 UTC 
This needs to happy on the neutral buttons, this was an oversight, the Neutral (white) buttons should NOT have drop shadow on the text, Steven you are correct. The color buttons are as designed.
Comment 4 Steven Walling 2014-03-17 18:35:13 UTC 
(In reply to Jared Zimmerman (WMF) from comment #3)
> This needs to happy on the neutral buttons, this was an oversight, the
> Neutral (white) buttons should NOT have drop shadow on the text, Steven you
> are correct. The color buttons are as designed.

Yeah sorry, by "default" I meant the neutral buttons.
Comment 5 Gerrit Notification Bot 2014-06-26 21:27:49 UTC 
Change 142426 had a related patch set uploaded by Robmoen:
Remove text shadow from default mediawiki.ui buttons

https://gerrit.wikimedia.org/r/142426
Comment 6 Gerrit Notification Bot 2014-06-26 21:37:28 UTC 
Change 142426 merged by jenkins-bot:
Remove text shadow from default mediawiki.ui buttons

https://gerrit.wikimedia.org/r/142426
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links