Last modified: 2014-02-27 09:53:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63990, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61990 - Live preview of languages removes labels from the Language Panel
Live preview of languages removes labels from the Language Panel
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Santhosh Thottingal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-27 09:33 UTC by Runa Bhattacharjee
Modified: 2014-02-27 09:53 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of wrong labels on ULS language live preview (77.54 KB, image/png)
2014-02-27 09:34 UTC, Runa Bhattacharjee
Details

Description Runa Bhattacharjee 2014-02-27 09:33:06 UTC
When changing interface language from the ULS Language Panel, the live preview removes the labels from all the widgets.

Steps to reproduce:
1. Go to a wiki running ULS e.g. http://mlebtesting.wmflabs.org/master/core/index.php/Main_Page
2. Log in (or create a login)
3. Go to ULS Language Panel (cog icon on Interlanguage wikis)
4. Go to the display language selection section : Display Settings -> Language
5. Select a different language
6. Observe the panel

Expected:
The live preview will display the panel and its labels in the selected language.

Actual:
The preview is shown without the correct label text. Eg: http://i.imgur.com/UNsxYdm.png

Additional information:
The user may have to change the language more than once to see the incorrect behaviour
Comment 1 Runa Bhattacharjee 2014-02-27 09:34:55 UTC
Created attachment 14699 [details]
Screenshot of wrong labels on ULS language live preview
Comment 2 Amir E. Aharoni 2014-02-27 09:35:19 UTC
Thanks for the report.

I suspect that this happens because of the recent change with fallback loading in jquery.i18n:

https://github.com/wikimedia/jquery.i18n/commit/b57e74da1451c44cb070c5101b0785ab7d139989#diff-40046c8e20fd36a2d935c555f0dbebbfR159

https://gerrit.wikimedia.org/r/#/c/107179/
Comment 3 Amir E. Aharoni 2014-02-27 09:37:31 UTC
When changing to Russian, loading the messages is done using a URL like this one:
http://mlebtesting.wmflabs.org/legacy-stable-interlanguage/core/api.php?action=ulslocalization&language=ru/en.json

"language=ru/en.json" doesn't look like a correct parameter, but I may be missing something.
Comment 4 Gerrit Notification Bot 2014-02-27 09:50:13 UTC
Change 115875 had a related patch set uploaded by Santhosh:
Fix: Live preview of languages removes labels from the language panel

https://gerrit.wikimedia.org/r/115875
Comment 5 Gerrit Notification Bot 2014-02-27 09:52:44 UTC
Change 115875 merged by jenkins-bot:
Fix: Live preview of languages removes labels from the language panel

https://gerrit.wikimedia.org/r/115875

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links