Last modified: 2014-03-05 13:30:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63992, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61992 - Vertical buttons instead of horizontal
Vertical buttons instead of horizontal
Status: RESOLVED DUPLICATE of bug 61922
Product: MediaWiki extensions
Classification: Unclassified
GettingStarted (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-27 10:30 UTC by Jan Ainali
Modified: 2014-03-05 13:30 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot of button placement. (24.95 KB, image/png)
2014-02-27 10:30 UTC, Jan Ainali
Details
In Monobook (207.19 KB, image/png)
2014-02-27 13:11 UTC, Lokal_Profil
Details

Description Jan Ainali 2014-02-27 10:30:03 UTC
Created attachment 14700 [details]
screenshot of button placement.

On Swedish Wikipedia, the button for finding an article to fix is placed underneath the guide button, instead of to the right, causing the window to get a scroll bar. Either the window should be made bigger to avoid scrolling or the button should be placed to the right.

(Tested in Chrome and Firefox on Ubuntu.)
Comment 1 Lokal_Profil 2014-02-27 13:11:03 UTC
Just tested the above in different skins:
* Vector: I get the above result
* Monobok: I get the correct result (see attachment)
* Modern: I get nothing
* Cologne: I get nothing

(All in Firefox)
Comment 2 Lokal_Profil 2014-02-27 13:11:33 UTC
Created attachment 14701 [details]
In Monobook
Comment 3 Lokal_Profil 2014-02-27 13:56:09 UTC
Testing uselang=qqx [1] it looks like the source of the problem might be in the text on the edit button doesn't wrap (unlike that of the fix button). As a result if the text is to long the button becomes wider than the default, something which the overlay box does not take into account when determining its width. Which is why you get the error in Swedish but not English.

[1] https://sv.wikipedia.org/wiki/Myinodes_interpunctaria?gettingStartedReturn=true&uselang=qqx
Comment 4 Lokal_Profil 2014-02-27 14:38:38 UTC
A fix for the problem is changing #mw-gettingstarted-editable-main-edit-page from "min-width: 210px" to "width: 210px". (Although not the best solution imho)
Comment 5 Matthew Flaschen 2014-02-27 18:55:26 UTC
The window is already fixed so there will be no vertical scrollbar.  This will roll out to all Wikipedias March 6.

As for putting the buttons on the same line in all languages, that is bug 61922, so I'll mark this a duplicate.

*** This bug has been marked as a duplicate of bug 61922 ***
Comment 6 Matthew Flaschen 2014-02-27 19:00:28 UTC
(In reply to Lokal_Profil from comment #1)
> Just tested the above in different skins:
> * Vector: I get the above result
> * Monobok: I get the correct result (see attachment)
> * Modern: I get nothing
> * Cologne: I get nothing

What do you mean, "I get nothing".  I see:

Modern (https://sv.wikipedia.org/wiki/Myinodes_interpunctaria?gettingStartedReturn=true&useskin=modern) - Buttons side by side.

ColoneBlue (https://sv.wikipedia.org/wiki/Myinodes_interpunctaria?gettingStartedReturn=true&useskin=cologneblue) - Buttons vertically

Where the buttons are might vary, but it should work.
Comment 7 Lokal_Profil 2014-03-03 12:20:10 UTC
(In reply to Matthew Flaschen from comment #6)
> (In reply to Lokal_Profil from comment #1)
> > Just tested the above in different skins:
> > * Vector: I get the above result
> > * Monobok: I get the correct result (see attachment)
> > * Modern: I get nothing
> > * Cologne: I get nothing
> 
> What do you mean, "I get nothing".  I see:
> 
> Modern
> (https://sv.wikipedia.org/wiki/
> Myinodes_interpunctaria?gettingStartedReturn=true&useskin=modern) - Buttons
> side by side.
> 
> ColoneBlue
> (https://sv.wikipedia.org/wiki/
> Myinodes_interpunctaria?gettingStartedReturn=true&useskin=cologneblue) -
> Buttons vertically
> 
> Where the buttons are might vary, but it should work.

Looked closer at this (CologneBlue and Modern) and not sure what is going on.
Firefox (27.0.1): 
* I don't see any buttons for when logged in to my normal account(s)
* Buttons appear when logged out.
* Buttons appear when logged in to a fresh account
Chrome:
* Buttons appear independently of whether I'm logged in.

Seems like it is a clash between the code for moving categories to the top of the page in my common.js (same as that in the Commons gadget https://commons.wikimedia.org/wiki/MediaWiki:Gadget-CategoryAboveAll.js) which doesn't affect those skins anyhow.
Comment 8 Steven Walling 2014-03-03 13:59:43 UTC
(In reply to Matthew Flaschen from comment #6)
> (In reply to Lokal_Profil from comment #1)
> > Just tested the above in different skins:
> > * Vector: I get the above result
> > * Monobok: I get the correct result (see attachment)
> > * Modern: I get nothing
> > * Cologne: I get nothing
> 
> What do you mean, "I get nothing".  I see:
> 
> Modern
> (https://sv.wikipedia.org/wiki/
> Myinodes_interpunctaria?gettingStartedReturn=true&useskin=modern) - Buttons
> side by side.
> 
> ColoneBlue
> (https://sv.wikipedia.org/wiki/
> Myinodes_interpunctaria?gettingStartedReturn=true&useskin=cologneblue) -
> Buttons vertically
> 
> Where the buttons are might vary, but it should work.

Yeah I think this is acceptable for now. 

Keep in mind that an overwhelming majority of editors who will be seeing this interface will see it with Vector. This is because it shows you the modals right after you register, and thus in order to switch skins they would need to be dismissed or you would have to open Preferences in a new tab then refresh the page.
Comment 9 Matthew Flaschen 2014-03-04 19:10:54 UTC
(In reply to Lokal_Profil from comment #7)
> Seems like it is a clash between the code for moving categories to the top
> of the page in my common.js (same as that in the Commons gadget
> https://commons.wikimedia.org/wiki/MediaWiki:Gadget-CategoryAboveAll.js)
> which doesn't affect those skins anyhow.

The reason it doesn't affect those skins is that bodyContent doesn't exist there.  However, the script throws an error rather than correctly handling the absence.  See https://commons.wikimedia.org/wiki/MediaWiki_talk:Gadget-CategoryAboveAll.js
Comment 10 Lokal_Profil 2014-03-05 13:30:07 UTC
(In reply to Matthew Flaschen from comment #9)
> (In reply to Lokal_Profil from comment #7)
> > Seems like it is a clash between the code for moving categories to the top
> > of the page in my common.js (same as that in the Commons gadget
> > https://commons.wikimedia.org/wiki/MediaWiki:Gadget-CategoryAboveAll.js)
> > which doesn't affect those skins anyhow.
> 
> The reason it doesn't affect those skins is that bodyContent doesn't exist
> there.  However, the script throws an error rather than correctly handling
> the absence.  See
> https://commons.wikimedia.org/wiki/MediaWiki_talk:Gadget-CategoryAboveAll.js

Thanks. So unrelated issue which prevented gettingStarted from showing. Updated the commons gadget, unsure if the same also exists on other projects.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links