Last modified: 2014-08-21 19:44:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64006, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62006 - VisualEditor: Create relocatable markers for complex shapes, e.g. block templates
VisualEditor: Create relocatable markers for complex shapes, e.g. block templ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High minor
: VE-deploy-2014-07-03
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-27 17:22 UTC by James Forrester
Modified: 2014-08-21 19:44 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2014-02-27 17:22:25 UTC
Right now you can re-position an inline transclusion in the same way as images, with a click-drag feature. Unfortunately this isn't set for block transclusions.

This is particularly irritating for suers because when you initially insert a transclusion we assume it's inline, so let them move it, but then when they re-open the page it's now magically un-moveable.
Comment 1 Ed Sanders 2014-02-28 16:43:25 UTC
Relocatable doesn't work on block elements atm. We have it enabled for block images, but it breaks.
Comment 2 Ed Sanders 2014-02-28 16:45:30 UTC
Disable on block images for now: https://gerrit.wikimedia.org/r/#/c/116118/
Comment 3 Ed Sanders 2014-02-28 17:08:40 UTC
Abandoned that, the test case I was using appears to be an edge case, it actually works ok.
Comment 4 Ed Sanders 2014-02-28 18:14:48 UTC
The problem here is not block templates, but that the CE HTML is <div wrapper><table float:right/></div>, and the relocatable marker takes it's dimensions from the <div> (which has no height).

In ProtectedNode we solve this by drawing boxes around _every_ descendent. Ideally we'll come up with a better solution before we start add drag handlers to them.
Comment 5 James Forrester 2014-07-09 19:42:41 UTC
Was this fixed by the changes to GCNs?
Comment 6 James Forrester 2014-08-21 19:44:05 UTC
I'm declaring that it was.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links