Last modified: 2014-03-13 22:45:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64010, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62010 - MFResourceLoaderModule::getLastModified is a hack
MFResourceLoaderModule::getLastModified is a hack
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
: 62004 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-27 18:33 UTC by Jon
Modified: 2014-03-13 22:45 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-02-27 18:33:59 UTC 
It doesn't actually reflect changes in the module meaning it can lead to serious caching issues such as in bug 62004
Comment 1 Jon 2014-02-27 18:34:47 UTC 
*** Bug 62004 has been marked as a duplicate of this bug. ***
Comment 2 Jon 2014-02-27 18:54:45 UTC 
The last modified time will currently only change when MobileFrontend.php or MobileFrontend.i18n.php change. This means it shouldn't cause issues in a weekly/daily deployment schedule but will be a problem when deployments are more rapid.
Comment 3 Gerrit Notification Bot 2014-02-27 18:57:00 UTC 
Change 115952 had a related patch set uploaded by Jdlrobson:
Update last modified time when a template or file changes in MFResourceLoaderModule

https://gerrit.wikimedia.org/r/115952
Comment 4 Jon 2014-02-27 19:04:24 UTC 
jdlrobson: Originally the timestamp only needed to change when a template file or a message changed but now it inherits from ResourceLoaderFileModule it also needs to pay attention to file changes
[11:01am] jdlrobson: some how we were paying attention to nothing directly related to the module (relying on i18n message changes)
Comment 5 Gerrit Notification Bot 2014-03-13 21:13:43 UTC 
Change 115952 merged by jenkins-bot:
Update last modified time when a template or file changes in MFResourceLoaderModule

https://gerrit.wikimedia.org/r/115952
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links