Last modified: 2014-03-03 19:41:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64019, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62019 - Metadata is missing for some images on mw.org
Metadata is missing for some images on mw.org
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-27 20:27 UTC by Tisza Gergő
Modified: 2014-03-03 19:41 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tisza Gergő 2014-02-27 20:27:41 UTC
The MediaViewer metadata panel is empty for some images on mediawiki.org
e.g. https://www.mediawiki.org/wiki/Lightbox_demo#mediaviewer/File:Casmerodius%20albus%20portrait.jpg

The bug is deterministic, only affects a few images, and only on mediawiki.org (the same images work fine on beta enwiki). There are no errors in the console. I don't see any obvious common feature. One of the affected images, https://www.mediawiki.org/wiki/Lightbox_demo#mediaviewer/File:Pentacle 3.svg doesn't even have an {{Information}} template.
Comment 1 Tisza Gergő 2014-02-27 20:29:53 UTC
At first glance seems like a promise rejection (we should have better logging of those). I tried to check with the code below whether any provider rejects, and didn't find anything, but maybe I messed up the code:

$.each( mw.mmv.provider, function ( providerName, provider ) {
  var oldGet = provider.get;
  provider.get = function () {
    oldGet.apply( provider, arguments ).then( null, function () {
      var d = $.Deferred();
      console.log( providerName + ' rejected!', arguments );
      return d.reject.apply( d, arguments );
    } );
  };
} );
Comment 2 Tisza Gergő 2014-02-28 02:39:30 UTC
Apparently I did mess up; the error is caused by the user provider rejecting when the user is missing. This does not happen for local and beta sites (local users always exist, and API repos are queried via JSONP so again the user always exist), only for ForeignDBRepo images (although I imagine it could happen when a user gets deleted/renamed with just the right timing).
Comment 3 Gerrit Notification Bot 2014-02-28 03:13:59 UTC
Change 116044 had a related patch set uploaded by Gergő Tisza:
Create fake user when userinfo request fails

https://gerrit.wikimedia.org/r/116044
Comment 4 Gerrit Notification Bot 2014-02-28 08:48:28 UTC
Change 116044 merged by jenkins-bot:
Create fake user when userinfo request fails

https://gerrit.wikimedia.org/r/116044
Comment 5 Gerrit Notification Bot 2014-03-03 17:33:10 UTC
Change 116506 had a related patch set uploaded by MarkTraceur:
Create fake user when userinfo request fails

https://gerrit.wikimedia.org/r/116506
Comment 6 Gerrit Notification Bot 2014-03-03 17:34:20 UTC
Change 116506 merged by jenkins-bot:
Create fake user when userinfo request fails

https://gerrit.wikimedia.org/r/116506

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links