Last modified: 2014-03-30 20:54:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64051, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62051 - AbuseFilter git master no longer compatible with MW 1.19
AbuseFilter git master no longer compatible with MW 1.19
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-28 13:30 UTC by Bartosz Dziewoński
Modified: 2014-03-30 20:54 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2014-02-28 13:30:16 UTC
AbuseFilter git master is no longer compatible with MW 1.19, and I'm pretty sure it used to be and it was intentional.

AbuseFilter change I72e1a6dd depends on core change Ia6415b39, which is only included in 1.20 and onward.

Code only mentions some backwards-compatibility checks for 1.20 and earlier, nothing about 1.19, so I might be wrong. This might also be unwanted. Either way let's decide instead of breaking compat accidentally. :)
Comment 1 Marius Hoch 2014-02-28 14:18:37 UTC
While I tried (and did) keep b/c for quite some time, I realized that this became harder over time and at some point it broke. After a discussion with Chris we need to reevalute this and decide whether we want to restore b/c or maintain branches for older MW versions.

CCing Markus as he might have an opinion on this (from a 3rd party point of view).
Comment 2 Andre Klapper 2014-02-28 16:29:54 UTC
This is a policy question for release engineering - so far I expected compatibility only for the current corresponding branch.
Comment 3 Bartosz Dziewoński 2014-02-28 17:03:46 UTC
(In reply to Andre Klapper from comment #2)
> This is a policy question for release engineering - so far I expected
> compatibility only for the current corresponding branch.

This currently depends on the specific extension. Some (especially ones actively being developed) break compatibility almost immediately, while some (for example several maintained by WMF's Language team) stay compatible with at least one or two MW versions back. (This is, sadly, usually not documented anywhere.)
Comment 4 Chris Steipp 2014-02-28 23:43:12 UTC
The extension has a REL1_19 branch (that should probably have a lot of updates applied to it). So we can keep parallel branches. Those are (supposed to be) what is distributed with the tarball.

We tried to keep AbuseFilter b/c for as long as possible. And if there are good ways to keep master working with 1.19, then we should make an effort to do that. But if we start limiting features, or the logic is less understandable because we're trying to support old versions, we should just rely on the branch to keep working with the old version of mediawiki.

Security issue should always be backported to the branches. I'm pretty sure we've done that.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links