Last modified: 2014-03-21 23:34:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64162, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62162 - Bad Flow diff link
Bad Flow diff link
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-03 20:16 UTC by Allen Stambaugh
Modified: 2014-03-21 23:34 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Allen Stambaugh 2014-03-03 20:16:06 UTC
The link https://www.mediawiki.org/w/index.php?title=Talk:Flow&workflow=rpx4cdyu8bls80rm&topic_oldRevision=rq5ggnhkuv7vogqg&topic_newRevision=rq5gfdhkeqju0av4&action=compare-revisions that I found on my watchlist leads to the following internal error massage.

"The action specified by the URL is invalid. You might have mistyped the URL, or followed an incorrect link. This might also indicate a bug in the software used by MediaWiki.
Return to MediaWiki.
[9733c713] 2014-03-03 20:09:17: Fatal exception of type Flow\Exception\InvalidActionException"
Comment 1 Maryana Pinchuk 2014-03-05 19:30:04 UTC
Thanks for the report, Allen. Just a few questions:

1) Is this your watchlist on English Wikipedia or Mediawiki.org?
2) Do you have any special watchlist preferences enabled?
3) Which link are you clicking to get to that URL? (e.g., "diff" or something like that?)
Comment 2 Maryana Pinchuk 2014-03-05 19:45:57 UTC
Oh, I think I found it :) On mw.org, when you edit a post, you get a (diff) link at the beginning of the watchlist string, and that generates the bad link.
Comment 3 Allen Stambaugh 2014-03-06 06:40:55 UTC
(In reply to Maryana Pinchuk from comment #1)
> Thanks for the report, Allen. Just a few questions:
> 
> 1) Is this your watchlist on English Wikipedia or Mediawiki.org?
> 2) Do you have any special watchlist preferences enabled?
> 3) Which link are you clicking to get to that URL? (e.g., "diff" or
> something like that?)

The link above should answer (and confirm what you wrote in comment 2) your first question and yes it is in the 'diff' link. As for my watchlist preferences it is 7 days and a maximum of 250 changes with the following advanced options checked.

* Add pages and files I edit to my watchlist
* Add pages and files I move to my watchlist
* Add pages I create and files I upload to my watchlist
* Watch threads that I create or reply to

I hope this helps.
Comment 4 bsitu 2014-03-11 00:45:12 UTC
Not sure why the bot is not pasting the gerrit link: https://gerrit.wikimedia.org/r/#/c/118040/
Comment 5 Gerrit Notification Bot 2014-03-12 17:25:35 UTC
Change 118040 had a related patch set uploaded by Addshore:
diff link for a post is action=compare-post-revisions

https://gerrit.wikimedia.org/r/118040
Comment 6 Gerrit Notification Bot 2014-03-13 23:09:42 UTC
Change 118040 merged by jenkins-bot:
diff link for a post is action=compare-post-revisions 

https://gerrit.wikimedia.org/r/118040
Comment 7 PiRSquared17 2014-03-16 15:43:31 UTC
Just noticed this bug. Thanks for the patch, Addshore.
Comment 8 PiRSquared17 2014-03-16 15:44:01 UTC
(In reply to PiRSquared17 from comment #7)
> Just noticed this bug. Thanks for the patch, Addshore.

* Bsitu
Comment 9 Gerrit Notification Bot 2014-03-18 00:51:19 UTC
Change 119230 had a related patch set uploaded by Bsitu:
More fix to diff link from contribution & recentchange page

https://gerrit.wikimedia.org/r/119230
Comment 10 bsitu 2014-03-18 00:55:18 UTC
Previous patch didn't take header revision into consideration. This should be addressed in the latest patch
Comment 11 Gerrit Notification Bot 2014-03-19 14:21:02 UTC
Change 119230 merged by jenkins-bot:
More fix to diff link from contribution & recentchange page

https://gerrit.wikimedia.org/r/119230

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links