Last modified: 2014-03-31 22:58:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64165, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62165 - Flow: garbled and generic "Internal error - {{SITENAME}}" for Flow error page titles
Flow: garbled and generic "Internal error - {{SITENAME}}" for Flow error page...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: bsitu
https://www.mediawiki.org/wiki/Talk:S...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-03 21:16 UTC by spage
Modified: 2014-03-31 22:58 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-03-03 21:16:59 UTC
= Part 1 =
Visit https://www.mediawiki.org/wiki/Talk:Sandbox?workflow=abcd , the h1 and page title are
  Internal error - {{SITENAME}}

Appending &uselang=qqx suggests the message is 
  (pagetitle: (internalerror))
  (flow-error-invalid-action)

So the pagetitle message is looked up, but isn't getting parsed.

= Part 2 =
Visit https://www.mediawiki.org/wiki/Talk:Sandbox?action=FOO , the h1 and page title are the same  Internal error - {{SITENAME}}
Flow's InvalidActionException->getErrorPageTitle() is returning the better title 'nosuchaction' for this error, but it isn't appearing.
Comment 1 Gerrit Notification Bot 2014-03-03 21:46:09 UTC
Change 116631 had a related patch set uploaded by Spage:
Fix error page titles

https://gerrit.wikimedia.org/r/116631
Comment 2 Kevin Israel (PleaseStand) 2014-03-04 05:04:36 UTC
(In reply to spage from comment #0)
> So the pagetitle message is looked up, but isn't getting parsed.

That is bug 58447.
Comment 3 spage 2014-03-04 20:24:49 UTC
(In reply to Kevin Israel (PleaseStand) from comment #2)
> (In reply to spage from comment #0)
> > So the pagetitle message is looked up, but isn't getting parsed.
> 
> That is bug 58447.
Beyond that bug, Flow is creating its own OutputPage object that has no message handling hooked up at all.
Comment 4 Gerrit Notification Bot 2014-03-19 00:59:31 UTC
Change 116631 abandoned by Spage:
Fix error page titles

Reason:
Yup, it's not this simple. I still think we can get ErrorPageError to do the work for us, just pass the full 'flow-error-CODE' at all times. It's crazy that ErrorPageError can't log the full $message text while displaying something friendlier to the user.

https://gerrit.wikimedia.org/r/116631
Comment 5 Gerrit Notification Bot 2014-03-25 00:26:58 UTC
Change 120708 had a related patch set uploaded by Bsitu:
Replace generic "Internal error - {{SITENAME}}" on error page

https://gerrit.wikimedia.org/r/120708
Comment 6 Gerrit Notification Bot 2014-03-25 18:08:12 UTC
Change 120708 merged by jenkins-bot:
Replace generic "Internal error - {{SITENAME}}" on error page

https://gerrit.wikimedia.org/r/120708

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links