Last modified: 2014-09-08 12:26:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64173, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62173 - Flow: ?action=edit on a Flow-enabled page or Topic namespace throws exception
Flow: ?action=edit on a Flow-enabled page or Topic namespace throws exception
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
https://www.mediawiki.org/wiki/Talk:F...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-04 00:50 UTC by spage
Modified: 2014-09-08 12:26 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-03-04 00:50:39 UTC
If you follow a redlink to a Flow board, you get an error page

  Internal error - {{SITENAME}}
  The action specified by the URL is invalid. You might have mistyped the URL, or followed an incorrect link. This might also indicate a bug in the software used by SPageWiki. 

and depending on how your wiki is configured for errors, you get:
  [0264606c] /wiki/index.php?title=User_talk:Selenium_user&action=edit&redlink=1 Exception from line 80 of /home/spage/projects/core/extensions/Flow/includes/View.php: Unrecognized get action: edit

Currently this is unlikely to happen in production, since we set up Flow in advance on a page-by-page basis. But when we allow Flow user pages, either by $wgFlowOccupyNamespaces or by a beta opt-in features, it's likely to happen.

We could make redlink handling aware of Flow so it just takes you to the Flow board instead of putting action=edit on the URL. But I think it's better and easier for Flow to swallow the exception for action=edit and let the user view the board, since that's the precursor to choosing something to edit (the board header, a topic title, or some post).

Maybe there are other MediaWiki-generated action links that should not result in action errors when performed on Flow boards.  We document action handling at https://www.mediawiki.org/wiki/Flow/Architecture#URL_actions

I filed bug 62165 about the garbled {{SITENAME}} in the title, it should be 'nosuchaction'.
Comment 1 Maryana Pinchuk 2014-03-05 19:23:23 UTC
Not high priority now since we're not rolling Flow out to new pages yet, thus not possible to get to Flow board via redlink.
Comment 2 Kunal Mehta (Legoktm) 2014-04-16 07:14:38 UTC
Note that it's not just redlinks, it's just ?action=edit that causes it.
Comment 3 Kunal Mehta (Legoktm) 2014-08-22 03:56:17 UTC
It's now throwing MWException's.
Comment 4 Jon 2014-09-08 12:26:22 UTC
I can't see any exceptions in this workflow. action=edit redirects to the Flow board.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links