Last modified: 2014-04-28 04:16:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64204, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62204 - Consider removing segmentCount
Consider removing segmentCount
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ContentTranslation (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Samyak Bhuta
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-04 14:03 UTC by Niklas Laxström
Modified: 2014-04-28 04:16 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2014-03-04 14:03:36 UTC 
It looks like we can save some code by removing the segmentCount variable. If the number is needed somewhere, we can probably use Object.keys( x ).length instead.
Comment 1 Amir E. Aharoni 2014-03-21 10:21:16 UTC 
Niklas, which file is it? Such a variable appears in several files.
Comment 2 Niklas Laxström 2014-03-21 15:55:59 UTC 
All the several files.
Comment 3 Gerrit Notification Bot 2014-04-25 22:09:15 UTC 
Change 129836 had a related patch set uploaded by Zilch:
Removes 'segmentCount' variable.

https://gerrit.wikimedia.org/r/129836
Comment 4 Gerrit Notification Bot 2014-04-28 04:13:26 UTC 
Change 129836 merged by jenkins-bot:
Removes 'segmentCount' variable.

https://gerrit.wikimedia.org/r/129836
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links