Last modified: 2014-03-10 14:43:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64242, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 62242 - Language.php L217: Invalid language code "[[:int:lang] "


Summary:	Language.php L217: Invalid language code "[[:int:lang] "

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Scribunto (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-05 01:07 UTC by Ori Livneh
Modified:	2014-03-10 14:43 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Exception log from fluorine (6.41 KB, text/plain) 2014-03-05 01:07 UTC, Ori Livneh	Details
Add an attachment (proposed patch, testcase, etc.)

Description Ori Livneh 2014-03-05 01:07:21 UTC

Created attachment 14739 [details]
Exception log from fluorine

To reproduce, visit <http://commons.wikimedia.org/wiki/User:Pere_prlpz/gallery/14>

One of the frames in the call stack is:
Scribunto_LuaSandboxCallback->formatNum('[[:int:lang]]U...', 41)

..which made me suspect Scribunto. But I haven't investigated.

Stack trace attached.

Comment 1 Bawolff (Brian Wolff) 2014-03-05 03:30:42 UTC

My initial reaction would be somebody doing mw.getLanguage( <random parsed wikitext here> ); - not enough error checking to handle the invalid language situation, Language::factory throws a MWException which nobody catches. But haven't looked into it to confirm that.

Comment 2 Gerrit Notification Bot 2014-03-05 16:41:01 UTC

Change 116984 had a related patch set uploaded by Anomie:
mw.language: Fix exceptions and add tests

https://gerrit.wikimedia.org/r/116984

Comment 3 Gerrit Notification Bot 2014-03-09 02:59:11 UTC

Change 116984 merged by jenkins-bot:
mw.language: Fix exceptions and add tests

https://gerrit.wikimedia.org/r/116984

Comment 4 Brad Jorsch 2014-03-10 14:43:42 UTC

This should be deployed to WMF wikis with 1.23wmf18, see https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links