Last modified: 2014-03-25 04:09:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64273, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 62273 - LocalFilePurgeThumbnails hook occurs after thumbnails cleared


Summary:	LocalFilePurgeThumbnails hook occurs after thumbnails cleared

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	File management (Other open bugs)
Version:	1.22.3
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-05 21:17 UTC by prodigion
Modified:	2014-03-25 04:09 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description prodigion 2014-03-05 21:17:40 UTC

In includes/filerepo/file/LocalFile.php, the hook LocalFilePurgeThumbnails appears to exist so that the wiki can purge thumbnails from caches.  However, since it occurs after the line:
		$this->purgeThumbList( $dir, $files );
It only returns the folder, not the files that (used to) exist.

Can we have the hook moved before the purgeThumbList code, in both instances?

Comment 1 Andre Klapper 2014-03-10 09:41:12 UTC

Thanks for taking the time to report this!

If you are interested in creating a patch to fix this and put it into Gerrit, please see https://www.mediawiki.org/wiki/Developer_access

Comment 2 Gerrit Notification Bot 2014-03-13 02:11:56 UTC

Change 118424 had a related patch set uploaded by Prod:
Execute LocalFilePurgeThumbnails hook before purging thumbnails

https://gerrit.wikimedia.org/r/118424

Comment 3 Gerrit Notification Bot 2014-03-14 22:48:25 UTC

Change 118424 merged by jenkins-bot:
Execute LocalFilePurgeThumbnails hook before purging thumbnails

https://gerrit.wikimedia.org/r/118424

Comment 4 prodigion 2014-03-25 04:09:45 UTC

This appears to now be sending a proper list of all the existing files so that I can have them properly purged.  Marking as RESOLVED FIXED.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links