Last modified: 2014-06-26 21:18:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64275, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62275 - MultimediaViewer should display license short name also for CC-BY-SA-XX
MultimediaViewer should display license short name also for CC-BY-SA-XX
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-05 21:31 UTC by Jean-Fred
Modified: 2014-06-26 21:18 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jean-Fred 2014-03-05 21:31:58 UTC
Creative Commons licenses have been ported in various jurisdictions, resulting in many variants CC-by-SA-XX (such as CC-by-SA-ee for Estonia).

MultimediaViewer should display the BY and SA icons for these licenses just like it does for CC-BY-SA

Example:
<https://www.mediawiki.org/wiki/Lightbox_demo#mediaviewer/File:Telleri%20kabel.jpg>

(This is also valid for CC-by-ee)
Comment 1 Tisza Gergő 2014-03-05 21:59:02 UTC
We never display any other icons than the CC logo, but we do display the name of the license as plain text after the logo in some cases, you probably mean that.

CommonsMetadata reports the license (correctly) as cc-by-sa-3.0-ee. The current MultimediaViewer behavior is to look for the multimediaviewer-license-<licensename> message, then fall back to multimediaviewer-license-default; the message is only defined for the main license variants.

We should either cut off the national part before looking for a message, or not use a message at all, and just display the license name as-is. Is there any benefit to using messages here? Does it make sense to translate strings like "CC-BY-SA-3.0"? Maybe to non-latin alphabets?
Comment 2 Jean-Fred 2014-03-05 22:52:28 UTC
(In reply to Tisza Gergő from comment #1)
> We never display any other icons than the CC logo, but we do display the
> name of the license as plain text after the logo in some cases, you probably
> mean that.

Yes of course you’re right (seems I have an integrated CC icons adder in my eyes ;-þ)

> CommonsMetadata reports the license (correctly) as cc-by-sa-3.0-ee. The
> current MultimediaViewer behavior is to look for the
> multimediaviewer-license-<licensename> message, then fall back to
> multimediaviewer-license-default; the message is only defined for the main
> license variants.

Oh, I see − as these messages are marked as optional I never noticed them in TranslateWiki.

Wouldn’t it make more sense to have these messages in Extension:Wikimedia Creative Commons license texts & Extension:Wikimedia license texts though? (if  it is possible to leverage on those from MMV afterwards of course?)

> We should either cut off the national part before looking for a message, or
> not use a message at all, and just display the license name as-is. Is there
> any benefit to using messages here? Does it make sense to translate strings
> like "CC-BY-SA-3.0"? Maybe to non-latin alphabets?

It appears to make sense, for languages like [ja] or [fa].

[fa] <https://creativecommons.org/licenses/by/3.0/deed.fa>
[ja] <https://creativecommons.org/licenses/by/3.0/deed.ja>
Comment 3 Tisza Gergő 2014-03-06 00:00:03 UTC
(In reply to Jean-Fred from comment #2)
> It appears to make sense, for languages like [ja] or [fa].
> 
> [fa] <https://creativecommons.org/licenses/by/3.0/deed.fa>
> [ja] <https://creativecommons.org/licenses/by/3.0/deed.ja>

Those also seem to use "CC-BY 3.0" as the short name, though.

> Wouldn’t it make more sense to have these messages in Extension:Wikimedia
> Creative Commons license texts & Extension:Wikimedia license texts though?
> (if  it is possible to leverage on those from MMV afterwards of course?)

I couldn't find those, did you mean Extension:WikimediaMessages? That is a (fairly ugly) hack to override generic translations with WMF-specific ones; it only makes sense when there is a generic message defined by some other extension.
(But it would be nice to have these texts at a more central location instead of MultimediaViewer, yeah.)
Comment 4 Jean-Fred 2014-03-06 00:08:13 UTC
(In reply to Tisza Gergő from comment #3)
> (In reply to Jean-Fred from comment #2)
> > It appears to make sense, for languages like [ja] or [fa].
> > 
> > [fa] <https://creativecommons.org/licenses/by/3.0/deed.fa>
> > [ja] <https://creativecommons.org/licenses/by/3.0/deed.ja>
> 
> Those also seem to use "CC-BY 3.0" as the short name, though.

Yeah. Short name (as defined in the license templates metadata) might be good enough in many cases ; I wonder about other licenses − the FAL comes to mind, but more generally the truckloads we have on Commons that may (or may not) need a localisation for their short name. But on top of my head, I think shortname would be good enough in most cases.

> > Wouldn’t it make more sense to have these messages in Extension:Wikimedia
> > Creative Commons license texts & Extension:Wikimedia license texts though?
> > (if  it is possible to leverage on those from MMV afterwards of course?)
> 
> I couldn't find those, did you mean Extension:WikimediaMessages? That is a
> (fairly ugly) hack to override generic translations with WMF-specific ones;
> it only makes sense when there is a generic message defined by some other
> extension.
> (But it would be nice to have these texts at a more central location instead
> of MultimediaViewer, yeah.)

Ah, I was using the names displayed in TranslateWiki without checking. Yes I meant [[Extension:WikimediaMessages]] & [[Extension:WikimediaLicenseTexts]] (which seem to be more or less part of the same thing?)
Comment 5 Tisza Gergő 2014-06-26 21:18:28 UTC
We display the shortname now if we don't have a matching message.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links