Last modified: 2014-03-08 01:23:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64285, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62285 - VisualEditor: Block slugs don't shrink back when selection moves to a FocusableNode
VisualEditor: Block slugs don't shrink back when selection moves to a Focusab...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-03-13
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-05 22:33 UTC by Roan Kattouw
Modified: 2014-03-08 01:23 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-03-05 22:33:49 UTC
1. Click in a block slug
2. The slug expands
3. Click in another paragraph
4. The slug contracts, as expected
5. Click in the slug again
6. The slug expands
7. Click on a FocusableNode (reference, template, etc.)
8. The slug doesn't contract
9. Click in a paragraph somewhere
10. Now the slug does contract

This is because contracting the slug when it's unfocused happens in pollOnceInternal, which is not invoked when selecting FocusableNodes (and only invoked by accident when changing the selection programmatically). onModelSelect in ce.Surface should probably clear the focusedness of the focused slug.
Comment 1 Gerrit Notification Bot 2014-03-06 16:41:19 UTC
Change 117214 had a related patch set uploaded by Esanders:
Fix application of slug focus classes

https://gerrit.wikimedia.org/r/117214
Comment 2 Gerrit Notification Bot 2014-03-08 01:08:48 UTC
Change 117214 merged by jenkins-bot:
Fix application of slug focus classes

https://gerrit.wikimedia.org/r/117214

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links