Last modified: 2014-03-08 01:05:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64345, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62345 - OOjs UI: Alignment and padding of icons in used in iconed ButtonWidget are a bit ugly
OOjs UI: Alignment and padding of icons in used in iconed ButtonWidget are a ...
Status: RESOLVED FIXED
Product: OOjs UI
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal minor
: ---
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-06 21:25 UTC by Rummana Yasmeen
Modified: 2014-03-08 01:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (57.69 KB, image/png)
2014-03-06 21:25 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-03-06 21:25:09 UTC 
Created attachment 14762 [details]
Screenshot

Right now the labels of the tabs Left, Center and Right are now aligned with the icons on them rather a bit misplaced upwards.Also, there should be a bit more spacing between the icon and the tab label.

See the screenshot attached.

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5
Comment 1 James Forrester 2014-03-07 00:23:45 UTC 
Trevor's in-person comments:

* More margin between the text and icon would be nice
* The images are ~1px too low because they're weighted down-file rather than up-file, and this should be reversed

These might have been butchered by me, sorry.
Comment 2 Ed Sanders 2014-03-07 15:49:53 UTC 
It appears you don't have the browser set to 100% zoom in the screenshot (ctrl+0)
Comment 3 Gerrit Notification Bot 2014-03-07 16:20:48 UTC 
Change 117422 had a related patch set uploaded by Esanders:
Balance margins around icon on iconed ButtonWidget

https://gerrit.wikimedia.org/r/117422
Comment 4 Gerrit Notification Bot 2014-03-08 00:05:33 UTC 
Change 117422 merged by jenkins-bot:
Balance margins around icon on iconed ButtonWidget

https://gerrit.wikimedia.org/r/117422
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links