Last modified: 2014-03-07 13:20:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64355, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62355 - returnto and returntoquery in login/signup links doesn't get updated on pushState or popstate
returnto and returntoquery in login/signup links doesn't get updated on pushS...
Status: NEW
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-07 02:01 UTC by Matthew Flaschen
Modified: 2014-03-07 13:20 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2014-03-07 02:01:46 UTC
VisualEditor uses pushState to add veaction=edit to the URL when you click the VE edit tab, without causing a true reload.  However, this does not cause a true reload.  Similarly, when you click Read, the same happens to go back to read mode.

Unfortunately, this does not update the returnto and returntoquery in the login and signup links.  So if you click the tab for VE, then go to login and signup in the top right, you will no longer be in VE when you get back.

VE could make a custom solution for this, but a general method might be nice.  

It's possible to listen to user-initiated navigation (e.g. back/forward) with the popstate event.  That could solve the problem for back and forward.

However, that doesn't tell you about pushState.  So perhaps there should be a mw.pushState that updates these links, then calls the underlying browser method.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links