Last modified: 2014-03-19 11:08:40 UTC
Exception on beta when trying to use http://wikidata.beta.wmflabs.org/wiki/Special:SetLabel. Guessing this is after merging the patch for bug 62211 This is not in our branch (wmf17) as it isnt happening on test.wikidata but is on master [2014-03-07 21:34:08] Catchable fatal error: Argument 2 passed to SpamBlacklistHooks::filterMergedContent() must implement interface Content, instance of Wikibase\DataModel\Entity\Item given at /data/project/apache/common-local/php-master/extensions/SpamBlacklist/SpamBlacklistHooks.php on line 19 Server: i-0000031b Method: POST URL: http://wikidata.beta.wmflabs.org/wiki/Special:SetLabel Backtrace: #0 /data/project/apache/common-local/php-master/extensions/SpamBlacklist/SpamBlacklistHooks.php(19): SpamBlacklistHooks::filterMergedContent() #1 [internal function]: SpamBlacklistHooks::filterMergedContent(Object(RequestContext), Object(Wikibase\DataModel\Entity\Item), Object(Status), '/* wbsetlabel-s...', Object(User), false) #2 /data/project/apache/common-local/php-master/includes/Hooks.php(206): call_user_func_array('SpamBlacklistHo...', Array) #3 /data/project/apache/common-local/php-master/includes/GlobalFunctions.php(4011): Hooks::run('EditFilterMerge...', Array, NULL) #4 /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(807): wfRunHooks('EditFilterMerge...', Array) #5 /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(739): Wikibase\EditEntity->runEditFilterHooks('/* wbsetlabel-s...') #6 /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/specials/SpecialWikibaseRepoPage.php(146): Wikibase\EditEntity->attemptSave('/* wbsetlabel-s...', 2, '+\') #7 /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/specials/SpecialModifyEntity.php(74): Wikibase\Repo\Specials\SpecialWikibaseRepoPage->saveEntity(Object(Wikibase\ItemContent), Object(Wikibase\Summary), '+\') #8 /data/project/apache/common-local/php-master/includes/specialpage/SpecialPage.php(374): Wikibase\Repo\Specials\SpecialModifyEntity->execute(NULL) #9 /data/project/apache/common-local/php-master/includes/specialpage/SpecialPageFactory.php(489): SpecialPage->run(NULL) #10 /data/project/apache/common-local/php-master/includes/Wiki.php(285): SpecialPageFactory::executePath(Object(Title), Object(RequestContext)) #11 /data/project/apache/common-local/php-master/includes/Wiki.php(588): MediaWiki->performRequest() #12 /data/project/apache/common-local/php-master/includes/Wiki.php(447): MediaWiki->main() #13 /data/project/apache/common-local/php-master/index.php(49): MediaWiki->run() #14 /data/project/apache/common-local/w/index.php(3): require('/data/project/a...') #15 {main}
So yes, Caused by line 807 in EditEntity if ( !wfRunHooks( 'EditFilterMergedContent', array( $context, $this->newEntity, &$filterStatus, $summary, $this->getUser(), false ) ) ) { We pass in $this->newEntity when it wants a Context object.. Introduced in https://gerrit.wikimedia.org/r/#/c/112934/
Change 117614 had a related patch set uploaded by Bene: (hotfix) prevent FatalError in EditEntity https://gerrit.wikimedia.org/r/117614
Change 117614 merged by jenkins-bot: Pass Content into EditFilterMergedContent instead of an Entity https://gerrit.wikimedia.org/r/117614
Approved the change
