Last modified: 2014-05-21 19:59:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64412, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 62412 - updateBitsBranchPointers points static-{stable,current} at subtly wrong content
updateBitsBranchPointers points static-{stable,current} at subtly wrong content
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
wmf-deployment
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-08 00:04 UTC by Bryan Davis
Modified: 2014-05-21 19:59 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bryan Davis 2014-03-08 00:04:08 UTC
The deployment prep scripts checkoutMediaWiki, deleteMediaWiki and updateWikiversions run the updateBitsBranchPointers script to maintain symlinks in the bits server's docroot. This script manages the contents of the static-current and static-stable directories.

In theory static-current should point to the static assets for the most recently deployed MW version and static-stable should point to the second oldest branch. Currently the script determines these versions not by reading wikiversions.{json,cdb} but by finding all the php-* directories in /usr/local/apache/common-local.

The checkoutMediaWiki is used to provision newly created branches on the deploy staging server (tin). One would assume that when this operation is complete the symlinks in static-current should point to the newly created branch as upon the next cluster sync (scap) that new branch will be the most current version of MW deployed. It turns out however that since this operation is performed in the staging directory (/a/common) rather than the deploy directory (/usr/local/apache/common-local) updateBitsBranchPointers will select the branch that was provisioned in the last branch deploy cycle rather than the in progress deploy cycle.

At the moment I can't link to a commit in operations/mediawiki-config.git showing this mistake in action as separate bug that was recently fixed [0] in updateBitsBranchPointers has prevented the symlinks for static-{current,stable} from being updated at all since the 1.23wmf10 branch was deployed.

[0]: https://gerrit.wikimedia.org/r/117618
Comment 1 Bryan Davis 2014-03-13 16:20:56 UTC
Now that the other bug is fixed, you can see this behavior in https://gerrit.wikimedia.org/r/#/c/118553. static-stable is pointed to php-1.23wmf16 instead of expected php-1.23wmf17 and static-current points to php-1.23wmf17 instead of expected php-1.23wmf18.
Comment 2 Bryan Davis 2014-03-31 22:43:47 UTC
This may actually be the intended behavior the more I think about it. With the existing logic, static-current tracks the version deployed to group1 wikis (non-test, non-wikipedias) and static-stable tracks the version deployed to group2 (wikipedias).
Comment 3 Bryan Davis 2014-05-21 19:59:09 UTC
I think this actually works correctly even it it is slightly unintuitive.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links